Skip to content

Check for null password or lack of network #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samtstern merged 1 commit into from
Sep 23, 2016
Merged

Check for null password or lack of network #308

samtstern merged 1 commit into from
Sep 23, 2016

Conversation

@samtstern
Copy link
Contributor

@samtstern samtstern commented Sep 16, 2016

@samtstern
Copy link
Contributor Author

samtstern commented Sep 16, 2016

@amandle please review.

@samtstern
Copy link
Contributor Author

samtstern commented Sep 22, 2016

@puf or @amandle PTAL

amandle
amandle approved these changes Sep 23, 2016
View reviewed changes
Copy link
Contributor

@amandle amandle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samtstern samtstern merged commit df0eca0 into firebase:version-1.0.0-dev Sep 23, 2016
@samtstern samtstern mentioned this pull request Sep 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@amandle amandle amandle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@amandle amandle

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samtstern @amandle