Skip to content

Conversation

@SUPERCILEX
Copy link
Collaborator

Style nit: style guide says emums should be in caps.

@puf
Copy link
Contributor

puf commented Oct 3, 2016

I have no problem with the change itself. But keep in mind that this is a change to a public interface, so must happen pre-1.0 or in a major. :-/

@samtstern
Copy link
Contributor

@puf actually I don't believe this is a public interface change since OnChangedListener is a child of FirebaseArray which is package protected. When I try to create a new instance of OnChangedListener in my class I get:

"com.firebase.ui.database.FirebaseArray" is not public in "com.firebase.ui.database".  Cannot be accessed from outside package.

@samtstern
Copy link
Contributor

@puf are you ok with this change given my previous comment?

@puf
Copy link
Contributor

puf commented Oct 4, 2016

Yup.

On Tue, Oct 4, 2016 at 8:49 AM Sam Stern notifications@github.com wrote:

@puf https://github.com/puf are you ok with this change given my
previous comment?


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#336 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA3w3wrmMGCyO22CqiTzHnxxhAiUZR6tks5qwnWjgaJpZM4KME07
.

@samtstern samtstern merged commit 8e5ec74 into firebase:master Oct 4, 2016
@samtstern
Copy link
Contributor

Merged, @SUPERCILEX thanks!

@SUPERCILEX SUPERCILEX deleted the database-style-cleanup branch October 4, 2016 17:23
@SUPERCILEX
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants