-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Make RecyclerViewDemoActivity.ChatHolder public #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from FirebaseRecyclerViewAdapter.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
from FirebaseRecyclerViewAdapter.
…se/FirebaseUI-Android into yg-fix-recycler-view-demo
…se/FirebaseUI-Android into yg-fix-recycler-view-demo
…se/FirebaseUI-Android into yg-fix-recycler-view-demo
Contributor
Author
|
I signed it! |
|
CLAs look good, thanks! |
TomWayne98
pushed a commit
to TomWayne98/FirebaseUI-Android
that referenced
this pull request
Mar 6, 2017
TomWayne98
pushed a commit
to TomWayne98/FirebaseUI-Android
that referenced
this pull request
Oct 25, 2017
update support library -> 25.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug that ChatHolder is not public so it could not be accessed, which causes crash.
@puf Can you review? Thanks!