Logout of Twitter

[SUPERCILEX]

#644

[SUPERCILEX]

@samtstern Signing out of Twitter and Facebook should probably a method (something like signOutProviders), but that will cause more thrashing in #609. Would you like me to do the refactor anyway and then undo it in #609 or are we not going through with #609?

[samtstern]

Let's keep sign out all as one method for now.

[SUPERCILEX]

SGTM!

[samtstern]

I think we also want to call:
Twitter.getSessionManager().clearActiveSession();

[SUPERCILEX]

@samtstern I thought so too, but Twitter.logOut() already does that for us:

// In Twitter.java
public static void logOut() {
    checkInitialized();
    getInstance().core.logOut(); // core == TwitterCore
}

// In TwitterCore.java
public void logOut() {
    checkInitialized();
    final SessionManager<TwitterSession> sessionManager = getSessionManager();
    if (sessionManager != null) {
        sessionManager.clearActiveSession();
    }
}

public static SessionManager<TwitterSession> getSessionManager() {
    checkInitialized();
    return getInstance().core.getSessionManager(); // Same reference as logOut in TwitterCore.java
}

Actually, now that I'm paying more attention, it looks like that's all Twitter#logOut() does.

The docs for TwitterCore#logOut() say it logs the user out, so I think that's all we have to do:

/**
 * Logs out the user, clearing user session. This will not make a network request to invalidate
 * the session.
 *
 * @throws java.lang.IllegalStateException if {@link io.fabric.sdk.android.Fabric}
 *          or {@link TwitterCore} has not been initialized.
 */

[samtstern]

Thanks for digging, works for me!

The Twitter docs don't have anything at all on signOut ... oversight I guess.