Add supported providers annotation #700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted-providers-annotation # Conflicts: # auth/src/main/java/com/firebase/ui/auth/provider/FacebookProvider.java # auth/src/main/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivity.java # auth/src/main/java/com/firebase/ui/auth/ui/idp/CredentialSignInHandler.java
…ted-providers-annotation # Conflicts: # auth/src/main/java/com/firebase/ui/auth/IdpResponse.java # auth/src/main/java/com/firebase/ui/auth/provider/FacebookProvider.java # auth/src/main/java/com/firebase/ui/auth/provider/GoogleProvider.java # auth/src/main/java/com/firebase/ui/auth/provider/TwitterProvider.java # auth/src/main/java/com/firebase/ui/auth/ui/User.java # auth/src/main/java/com/firebase/ui/auth/ui/accountlink/WelcomeBackPasswordPrompt.java # auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailActivity.java # auth/src/main/java/com/firebase/ui/auth/ui/email/RegisterEmailFragment.java # auth/src/main/java/com/firebase/ui/auth/util/signincontainer/SignInDelegate.java # auth/src/test/java/com/firebase/ui/auth/testhelpers/FakeAuthResult.java # auth/src/test/java/com/firebase/ui/auth/ui/email/RegisterEmailActivityTest.java # auth/src/test/java/com/firebase/ui/auth/ui/email/WelcomeBackPasswordPromptTest.java # auth/src/test/java/com/firebase/ui/auth/ui/idp/AuthMethodPickerActivityTest.java # auth/src/test/java/com/firebase/ui/auth/ui/idp/CredentialSignInHandlerTest.java
…ted-providers-annotation # Conflicts: # auth/src/main/java/com/firebase/ui/auth/ui/idp/CredentialSignInHandler.java
SUPERCILEX
commented
May 11, 2017
| FacebookAuthProvider.PROVIDER_ID, FACEBOOK_PROVIDER, | ||
| TwitterAuthProvider.PROVIDER_ID, TWITTER_PROVIDER | ||
| }) | ||
| public @interface SupportedProvider {} |
Collaborator
Author
There was a problem hiding this comment.
Do we want this to be public? I feel like it could be useful, but it also means we have to maintain backwards compatibility...
| cleanup(); | ||
| } | ||
|
|
||
| public void cleanup() { |
Collaborator
Author
There was a problem hiding this comment.
@samtstern What size level of changes do you want me to split into other PRs? I'm happy to move this to another PR. (it was just a small nit Intellij complained about)
…ted-providers-annotation
Collaborator
Author
|
@samtstern do you want to take a look at this one before 2.0? I think it's a nice improvement to help devs know what they should be passing in for the provider. |
Contributor
|
@SUPERCILEX yep I'll add this one to 2.0 milestone |
Collaborator
Author
|
@samtstern cool! |
Contributor
|
Forgot about this one, gonna merge it! |
Collaborator
Author
|
Awesome possum! Gonna go merge stuff now 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samtstern While doing some debugging, I made a typo and passed in a hardcoded string to the
IdpBuilder#setProvidermethod that ended in a runtime exception. 😢 I think we can be fancier with our supported providers so this PR add our ownSupportedProviderannotation. 😎:smile:Here's an example error:
PS: sorry for the yucky commit history, I built it off another PR.