Update style guide #712
Merged
Update style guide #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Oh and I also made the style guide add a space to the end of a tag since that seems to be the convention. |
Contributor
|
Thanks for this! Just FYI I want to leave this until after version 2.0 since it touches a lot of files and is just cosmetic. |
Collaborator
Author
|
@samtstern yup, makes sense! |
# Conflicts: # auth/src/main/res/drawable/idp_button_background_facebook.xml # auth/src/main/res/drawable/idp_button_background_twitter.xml
Collaborator
Author
|
@samtstern Ok, merged from master! |
Contributor
|
Gonna merge this one into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samtstern While working on #711 the auto formatting was doing everything alphabetically which makes no sense with
ConstraintLayoutsinceconstraintBottom_...would end up first andconstraintTop_...would end up last. This PR updates the style guide so that everything is ordered the following way (includingandroid:layout...andandroid:padding...):