Revert reauthentication #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I9953ce08d719ef3dabd7077fc48b0c78c3f68747
Collaborator
|
@samtstern Aw dang, that's so sad. 😢 I guess it had to be done. |
Contributor
Author
|
@SUPERCILEX the good news is I deleted only what I had to. The intent builder is still generic, etc. So I think when it comes time to re-implement we will have no trouble. |
Collaborator
|
@samtstern Oh, that's true! I looked at the changes and it seems like there shouldn't be too many merge conflicts with existing PRs. Awesome! 😄 |
Change-Id: Iaea9011195d15faae9d108fee98d1dd721746512
Change-Id: I307100178642f5b467de89251bd0744992c0a1df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #715, we have to remove re-authentication for version 2.0.0 because there has not been enough bandwidth to implement on other platforms and we want to conserve a consistent UI surface.