Remove unnecessary immutable stuff #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@SUPERCILEX this is great, thank you for finding this improvement. I am happy to include this in 2.0 once the merge conflict is fixed. |
…n-2.0.0-dev # Conflicts: # database/src/main/java/com/firebase/ui/database/ImmutableList.java
Collaborator
Author
|
@samtstern Cool beans, merged! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #737
@samtstern When I first wrote the refactor, I didn't know
AbstractListwas a thing. Now I do! 😄 It's immutable by default and handles a ton of stuff for us so we don't have to deal with it which is really nice.Also, as long as #737 is merged this can happen after 2.0 is released.