Changed order of parameters in constructor of "Chat" class #758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All examples of the `new Chat(...)` constructor being used in the code assume the message is the 3rd parameter passed to the constructor and not the 2nd.
Contributor
|
@pizza thanks for catching that! Looks like we do the opposite outside of the README, but this at least keeps the README consistent with itself. Also your username is fantastic 🍕 👍 |
Contributor
Author
|
Thanks Sam! 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All examples of the
new Chat(...)constructor being used in the code assume the message is the 3rd parameter passed to the constructor and not the 2nd.