Skip to content

Fix Fragment getContext NPE #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samtstern merged 1 commit into from
Jun 29, 2017
+10 −1
Merged

Fix Fragment getContext NPE #781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion auth/src/main/java/com/firebase/ui/auth/ui/phone/VerifyPhoneNumberFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
package com.firebase.ui.auth.ui.phone;

import android.app.PendingIntent;
import android.content.Context;
import android.content.Intent;
import android.content.IntentSender;
import android.os.Bundle;
Expand Down Expand Up @@ -52,6 +53,8 @@
public class VerifyPhoneNumberFragment extends FragmentBase implements View.OnClickListener {
public static final String TAG = "VerifyPhoneFragment";

private Context mAppContext;

private CountryListSpinner countryListSpinner;
private EditText mPhoneEditText;
private TextView errorEditText;
Expand All @@ -73,6 +76,12 @@ public static VerifyPhoneNumberFragment newInstance(FlowParameters flowParameter
return fragment;
}

@Override
public void onAttach(Context context) {
super.onAttach(context);
mAppContext = context.getApplicationContext();
}

@Nullable
@Override
public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container, @Nullable
Expand Down Expand Up @@ -142,7 +151,7 @@ public void onActivityResult(int requestCode, int resultCode, Intent data) {
final String formattedPhone =
PhoneNumberUtils
.formatPhoneNumberUsingCurrentCountry(unformattedPhone,
getContext());
mAppContext);
if (formattedPhone == null) {
Log.e(TAG, "Unable to normalize phone number from hint selector:"
+ unformattedPhone);
Expand Down