Add true support for vector drawables #814
Conversation
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
|
|
||
| <style name="FirebaseUI.Button.AccountChooser.EmailButton"> | ||
| <item name="android:drawableLeft">@drawable/fui_ic_mail_white_24dp</item> | ||
| <item name="drawableStartCompat">@drawable/fui_ic_mail_white_24dp</item> |
There was a problem hiding this comment.
Pre-L this will crash with a res not found exception if we don't manually get the drawable with AppCompatResources.getDrawable.
There was a problem hiding this comment.
So is this the reason for the button subclass?
|
Oh nice! I'll take another look at this early next week (and your other PRs, I have been slacking on this repo). I remember when we went with vectors for Santa Tracker there were a bunch of gotchas and I just want to make sure they don't apply here (I think we're OK). |
|
@samtstern SGTM! (I also have another PR coming up 😊) |
|
Very cool to see this change! #vectorallthethings |
|
@samtstern Was this closed by accident or did you decide against it? |
|
@SUPERCILEX accident! Sorry haha. |
|
@samtstern 😄👍 |
# Conflicts: # auth/src/main/res/layout/fui_phone_progress_dialog.xml
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
app/src/main/res/values/config.xml
Outdated
| how obfuscated, makes it vulnerable to being stolen. | ||
| --> | ||
| <string name="twitter_consumer_secret" translatable="false">CHANGE-ME</string> | ||
| <string name="twitter_consumer_secret" translatable="false">di6UQRwDaxsRQ7RT5M5QcUgq19Dn4NY04QLMjaDhyxqmUy92Pe</string> |
There was a problem hiding this comment.
This seems like a mistake haha
|
|
||
| import com.firebase.ui.auth.R; | ||
|
|
||
| public class SupportVectorDrawablesButton extends AppCompatButton { |
There was a problem hiding this comment.
This class seems to have some cool but non-obvious compatibility tricks. Can you add comments (class level and in the one big method) explaining what's going on?
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
|
LGTM! |
3 participants
@samtstern I didn't know this at the time, but we were never actually getting the true benefits of vector drawables because the build tools would just convert them to pngs at the end of the day. I went through the pains of figuring out how to enable true vector drawable support for my app and I'm bringing this knowledge over to FUI. Yay! 😄
Turns out we actually save quite a few kbs considering how few drawables we have: