Add full support for Android O and update deps #850
Conversation
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
| tools:ignore="ResourceName"> | ||
|
|
||
| <style name="FirebaseUI.TextInputEditText.EmailField"> | ||
| <item name="android:autofillHints">emailAddress</item> |
There was a problem hiding this comment.
Hmm I wonder how this will play with smartlock. It could be annoying if they just turned down the smartlock hint and then autofill offers them a new hint.
There was a problem hiding this comment.
Oh, thanks for reminding me! I was going to disable password autofill if smart lock is enabled (because getting a save password prompt twice is really annoying).
As for the email, we could also disable autofill anytime smart lock is enabled because the only way the user could have reached the email field is if they didn't take the hint with smart lock enabled.
There was a problem hiding this comment.
I think that's a good idea, when smartlock is enabled disable other autofills. That's the path of least annoyance.
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
|
Woot! |
2 participants
@samtstern I've got a string of PRs lined up. This one updates deps, adds explicit autofill support, and does Android O cleanup.