Skip to content

test: SwiftUI integration tests and View tests for create user and sign-in #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
May 28, 2025

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented May 16, 2025

  • unit tests/integration tests for AuthService.
  • UI tests on Views for create user, sign-in flows and navigation between Views.

@russellwheatley russellwheatley changed the title chore: delete benchmark file test: SwiftUI integration tests and View tests for create user and sign-in May 16, 2025
@russellwheatley russellwheatley marked this pull request as ready for review May 22, 2025 07:51
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit or two.

@@ -25,11 +25,12 @@ struct ContentView: View {
actionCodeSettings.linkDomain = "flutterfire-e2e-tests.firebaseapp.com"
actionCodeSettings.setIOSBundleID(Bundle.main.bundleIdentifier!)
let configuration = AuthConfiguration(
shouldAutoUpgradeAnonymousUsers: true,
shouldAutoUpgradeAnonymousUsers: uiAuthEmulator ? false : true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be written as !uiAuthEmulator

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@russellwheatley russellwheatley merged commit 017479f into main May 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants