-
Notifications
You must be signed in to change notification settings - Fork 483
test: SwiftUI integration tests and View tests for create user and sign-in #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a nit or two.
@@ -25,11 +25,12 @@ struct ContentView: View { | |||
actionCodeSettings.linkDomain = "flutterfire-e2e-tests.firebaseapp.com" | |||
actionCodeSettings.setIOSBundleID(Bundle.main.bundleIdentifier!) | |||
let configuration = AuthConfiguration( | |||
shouldAutoUpgradeAnonymousUsers: true, | |||
shouldAutoUpgradeAnonymousUsers: uiAuthEmulator ? false : true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be written as !uiAuthEmulator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Uh oh!
There was an error while loading. Please reload this page.