Skip to content

fix: allow override of single/multiple strings whilst falling back to module bundle for any other string #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
russellwheatley merged 5 commits into from
Dec 9, 2025
Merged

fix: allow override of single/multiple strings whilst falling back to module bundle for any other string #1320

russellwheatley merged 5 commits into from
Dec 9, 2025

Conversation

@russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Dec 8, 2025 •
edited
Loading

fixes #1317

  • allow single/multiple strings to be overridden whilst falling back to modules default strings.
  • wrote unit tests to prove it works.
  • updated documentation on how to update strings.
  • Updated example with single string override for purpose of demonstration.

@russellwheatley russellwheatley changed the title fix: allow override of strings whilst falling back to module bundle fix: allow override of single/multpile strings whilst falling back to module bundle for any other string Dec 8, 2025
@russellwheatley russellwheatley marked this pull request as ready for review December 8, 2025 17:03
@russellwheatley russellwheatley changed the title fix: allow override of single/multpile strings whilst falling back to module bundle for any other string fix: allow override of single/multiple strings whilst falling back to module bundle for any other string Dec 9, 2025
@russellwheatley russellwheatley merged commit 8d616fa into main Dec 9, 2025
20 checks passed
@russellwheatley russellwheatley deleted the fallback-to-default-strings branch December 9, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

@demolaf demolaf demolaf approved these changes

Assignees

@russellwheatley russellwheatley

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please document how to add custom translations or overwrite the Strings in FirebaseAuthSwiftUI

3 participants

@russellwheatley @morganchen12 @demolaf