Skip to content

Add support for Facebook Limited Login. #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 8, 2021
Merged

Add support for Facebook Limited Login. #995

merged 8 commits into from
Oct 8, 2021

Conversation

rosalyntan
Copy link
Member

@rosalyntan rosalyntan commented Jul 26, 2021 •
edited
Loading

This adds support for Facebook Limited Login in FirebaseUI iOS.

To use Facebook Limited Login instead of Facebook Classic Login, set the useLimitedLogin property on the FUIFacebookAuth instance.

@google-cla google-cla bot added the cla: yes label Jul 26, 2021
morganchen12
morganchen12 approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had one lingering question.

@rosalyntan
Copy link
Member Author

Hi @morganchen12, do you happen to have any ideas why the Facebook Auth / spm (pull_request) check is failing? I don't see anything in my last commit that would cause it to fail, and it passed on all the previous commits.

@rosalyntan
Copy link
Member Author

Hi @morganchen12, do you happen to have any ideas why the Facebook Auth / spm (pull_request) check is failing? I don't see anything in my last commit that would cause it to fail, and it passed on all the previous commits.

Verified that the Facebook Auth / spm (pull_request) check is also failing on master: https://github.com/firebase/FirebaseUI-iOS/actions/runs/1262616275

@morganchen12
Copy link
Contributor

morganchen12 commented Sep 22, 2021 •
edited
Loading

Looks like a dependency change upstream broke the build:

The following build commands failed:
	CompileSwift normal x86_64 /Users/runner/Library/Developer/Xcode/DerivedData/FirebaseUI-iOS-evcpsltbtpeuifaedctjdqqcpomg/SourcePackages/checkouts/facebook-ios-sdk/Sources/FacebookCore/Exports.swift
	CompileSwift normal x86_64 /Users/runner/Library/Developer/Xcode/DerivedData/FirebaseUI-iOS-evcpsltbtpeuifaedctjdqqcpomg/SourcePackages/checkouts/facebook-ios-sdk/Sources/FacebookCore/Imports.swift
	CompileSwift normal x86_64 /Users/runner/Library/Developer/Xcode/DerivedData/FirebaseUI-iOS-evcpsltbtpeuifaedctjdqqcpomg/SourcePackages/checkouts/facebook-ios-sdk/Sources/FacebookCore/Swift/AccessToken.swift
	CompileSwift normal x86_64 /Users/runner/Library/Developer/Xcode/DerivedData/FirebaseUI-iOS-evcpsltbtpeuifaedctjdqqcpomg/SourcePackages/checkouts/facebook-ios-sdk/Sources/FacebookCore/Swift/Permission.swift
	CompileSwift normal i386 /Users/runner/Library/Developer/Xcode/DerivedData/FirebaseUI-iOS-evcpsltbtpeuifaedctjdqqcpomg/SourcePackages/checkouts/facebook-ios-sdk/Sources/FacebookCore/Exports.swift
	CompileSwift normal i386 /Users/runner/Library/Developer/Xcode/DerivedData/FirebaseUI-iOS-evcpsltbtpeuifaedctjdqqcpomg/SourcePackages/checkouts/facebook-ios-sdk/Sources/FacebookCore/Imports.swift
	CompileSwift normal i386 /Users/runner/Library/Developer/Xcode/DerivedData/FirebaseUI-iOS-evcpsltbtpeuifaedctjdqqcpomg/SourcePackages/checkouts/facebook-ios-sdk/Sources/FacebookCore/Swift/AccessToken.swift
	CompileSwift normal i386 /Users/runner/Library/Developer/Xcode/DerivedData/FirebaseUI-iOS-evcpsltbtpeuifaedctjdqqcpomg/SourcePackages/checkouts/facebook-ios-sdk/Sources/FacebookCore/Swift/Permission.swift
	CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler
	CompileSwift normal arm64 /Users/runner/Library/Developer/Xcode/DerivedData/FirebaseUI-iOS-evcpsltbtpeuifaedctjdqqcpomg/SourcePackages/checkouts/facebook-ios-sdk/Sources/FacebookCore/Exports.swift
	CompileSwift normal arm64 /Users/runner/Library/Developer/Xcode/DerivedData/FirebaseUI-iOS-evcpsltbtpeuifaedctjdqqcpomg/SourcePackages/checkouts/facebook-ios-sdk/Sources/FacebookCore/Imports.swift
	CompileSwift normal arm64 /Users/runner/Library/Developer/Xcode/DerivedData/FirebaseUI-iOS-evcpsltbtpeuifaedctjdqqcpomg/SourcePackages/checkouts/facebook-ios-sdk/Sources/FacebookCore/Swift/AccessToken.swift
	CompileSwift normal arm64 /Users/runner/Library/Developer/Xcode/DerivedData/FirebaseUI-iOS-evcpsltbtpeuifaedctjdqqcpomg/SourcePackages/checkouts/facebook-ios-sdk/Sources/FacebookCore/Swift/Permission.swift
(13 failures)
Command CompileSwift failed with a nonzero exit code

I'm ok to merge this change as-is and address the build breakage separately.

@rosalyntan rosalyntan marked this pull request as ready for review October 8, 2021 21:42
@rosalyntan rosalyntan merged commit 56dc3bf into master Oct 8, 2021
@rosalyntan rosalyntan deleted the rosalyntan.limited branch October 8, 2021 21:43
This was referenced Oct 11, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosalyntan @morganchen12