feat(firestore-bigquery-export): support cross-project import with the import script #1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to bigQueryProjectId
…e as param option
|
Hey @cabljac, Just wanted to share my thanks and appreciation for helping out here! :) |
|
You could use the PROJECT_ID as a fallback if no big query project id is provided to be downward compatible |
|
Hey there! Any news about this one? I've tested using 0.1.43 extension version, following @jwerner08's instructions, but for some reason BigQuery project Id was always being setted to "undefined". On the other way, if I manually overwrite project variables, everything runs perfectly. Having this functionality in a production branch would be amazing, it's quite easy to use and most of my jobs runs on cross projects. Thanks for the excellent work! |
…nvertase/@jwerner08/gcp-option
jauntybrain
changed the title
|
@jauntybrain can you resolve the conflict |
pr-Mais
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to replace the PR here as refactors have made the original fork diverge too much from
next. Need to re-review before we merge.Should fix #1688