feat(fcm): Implement SendEachAsync and SendEachForMulticastAsync
#343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SendEachAsync` vs `SendAllAsync`
1. `SendEachAsync` sends one HTTP request to V1 Send endpoint for each
message in the list.
`SendAllAsync` sends only one HTTP request to V1 Batch Send endpoint
to send all messages in the list.
2. `SendEachAsync` calls `Task.WhenAll` to wait for all
`httpClient.SendAndDeserializeAsync` calls to complete and construct
a `BatchResponse` with all `SendResponse`s.
An `httpClient.SendAndDeserializeAsync` call to V1 Send endpoint
either completes with a success or throws an exception. So if an
exception is thrown out, the exception will be caught in `SendEachAsync`
and turned into a `SendResponse` with an exception.
Therefore, unlike `SendAllAsync`, `SendEachAsync` does not always throw
an exception for a total failure. It can also return a `BatchResponse`
with only exceptions in it.
`SendEachForMulticastAsync` calls `SendEachAsync` under the hood.
Doris-Ge
force-pushed
the
dorisge/fcm-batch-send
branch
from
27e6ee1 to
6d6b20f
Compare
Doris-Ge
commented
Mar 29, 2023
| } | ||
| catch (Exception e) | ||
| { | ||
| var exception = new FirebaseMessagingException(ErrorCode.Unknown, $"{e}"); |
Contributor
Author
There was a problem hiding this comment.
Is it ok to put the exception into the SendResponse?
Member
There was a problem hiding this comment.
Seems like that's how we have handled exceptions in batch send. Add the responses in var responses = new List<SendResponse>(); with SendResponse.FromException(... for failed once.
Contributor
Author
There was a problem hiding this comment.
Sorry for the late response! My question was about whether it's ok to put the content of the Exception e into the SendResponse via $"{e}". Sorry for being unclear!
SendEach() and SendEachForMulticast()
lahirumaramba
changed the title
SendEachAsync and SendEachForMulticastAsyncSendEachAsync and SendEachForMulticastAsync
lahirumaramba
added
release-note
and removed
release-note
release:stage
lahirumaramba
approved these changes
Jun 5, 2023
| } | ||
| catch (Exception e) | ||
| { | ||
| var exception = new FirebaseMessagingException(ErrorCode.Unknown, $"{e}"); |
Member
There was a problem hiding this comment.
Seems like that's how we have handled exceptions in batch send. Add the responses in var responses = new List<SendResponse>(); with SendResponse.FromException(... for failed once.
Doris-Ge
added a commit
that referenced
this pull request
Jun 9, 2023
…M batch send (#348) * feat(fcm): Implement `SendEachAsync` and `SendEachForMulticastAsync` (#343) * Implement `SendEachAsync` and `SendEachForMulticastAsync` `SendEachAsync` vs `SendAllAsync` 1. `SendEachAsync` sends one HTTP request to V1 Send endpoint for each message in the list. `SendAllAsync` sends only one HTTP request to V1 Batch Send endpoint to send all messages in the list. 2. `SendEachAsync` calls `Task.WhenAll` to wait for all `httpClient.SendAndDeserializeAsync` calls to complete and construct a `BatchResponse` with all `SendResponse`s. An `httpClient.SendAndDeserializeAsync` call to V1 Send endpoint either completes with a success or throws an exception. So if an exception is thrown out, the exception will be caught in `SendEachAsync` and turned into a `SendResponse` with an exception. Therefore, unlike `SendAllAsync`, `SendEachAsync` does not always throw an exception for a total failure. It can also return a `BatchResponse` with only exceptions in it. `SendEachForMulticastAsync` calls `SendEachAsync` under the hood. * Add integration tests for the batch-send reimplementation: SendEach() and SendEachForMulticast() * Address the doc review comments
Doris-Ge
added a commit
that referenced
this pull request
Jul 25, 2023
…343) * Implement `SendEachAsync` and `SendEachForMulticastAsync` `SendEachAsync` vs `SendAllAsync` 1. `SendEachAsync` sends one HTTP request to V1 Send endpoint for each message in the list. `SendAllAsync` sends only one HTTP request to V1 Batch Send endpoint to send all messages in the list. 2. `SendEachAsync` calls `Task.WhenAll` to wait for all `httpClient.SendAndDeserializeAsync` calls to complete and construct a `BatchResponse` with all `SendResponse`s. An `httpClient.SendAndDeserializeAsync` call to V1 Send endpoint either completes with a success or throws an exception. So if an exception is thrown out, the exception will be caught in `SendEachAsync` and turned into a `SendResponse` with an exception. Therefore, unlike `SendAllAsync`, `SendEachAsync` does not always throw an exception for a total failure. It can also return a `BatchResponse` with only exceptions in it. `SendEachForMulticastAsync` calls `SendEachAsync` under the hood. * Add integration tests for the batch-send reimplementation: SendEach() and SendEachForMulticast()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SendEachAsyncvsSendAllAsyncSendEachAsyncsends one HTTP request to V1 Send endpoint for each message in the list.SendAllAsyncsends only one HTTP request to V1 Batch Send endpoint to send all messages in the list.SendEachAsynccallsTask.WhenAllto wait for allhttpClient.SendAndDeserializeAsynccalls to complete and construct aBatchResponsewith allSendResponses. AnhttpClient.SendAndDeserializeAsynccall to V1 Send endpoint either completes with a success or throws an exception. So if an exception is thrown out, the exception will be caught inSendEachAsyncand turned into aSendResponsewith an exception. Therefore, unlikeSendAllAsync,SendEachAsyncdoes not always throw an exception for a total failure. It can also return aBatchResponsewith only exceptions in it.SendEachForMulticastAsynccallsSendEachAsyncunder the hood.