Update passwordHash and passwordSalt to be base64 decoded before user import #775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Using the importWithScrypt() code snippet in the public doc will successfully import the user, but we will be unable to sign in because the password is changed.
This may be similar to this issue in Firebase Admin Go: https://github.com/firebase/firebase-admin-go/issues/479 and the fixes in https://github.com/firebase/firebase-admin-go/pull/480 and https://github.com/firebase/firebase-admin-python/pull/652
After this change, we can successfully import a user and sign in with the original password.
Note: I use
BaseEncoding.base64()
instead ofBaseEncoding.base64Url()
becauseBaseEncoding.base64Url().decode
will throw anUnrecognized character: +
exception if the password hash contains '+'.