feat(firestore): Add support for multiple named databases in Firestore #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-hui
approved these changes
May 31, 2023
| @@ -108,7 +108,7 @@ static Firestore getFirestore(FirebaseApp app, String database) { | |||
| * instance. | |||
There was a problem hiding this comment.
Hey folks, were these public docs were reviewed by a tech writer before merging the changes?
@tom-andersen @wu-hui
There was a problem hiding this comment.
We involved @markarndt in multidb texts last year. The changes were repetitive across SDKs, so he didn't review all of them.
Is the process now to have tech writers mark PRs directly with approval?
lahirumaramba
changed the title
|
@markarndt Could you leave a comment that you have reviewed the text in this PR? If you have any concerns, I will follow up with another PR to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTE: Added support for multiple named databases. This feature is currently in public preview.