Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Support for defaultSupportedIdpConfigs #844

Open
IainAdams opened this issue Apr 13, 2020 · 5 comments
Open

[FR] Support for defaultSupportedIdpConfigs #844

IainAdams opened this issue Apr 13, 2020 · 5 comments

Comments

@IainAdams
Copy link

Is your feature request related to a problem? Please describe.
The REST/GRPC API provides the ability to manage defaultSupportedIdpConfigs, however, this doesn't seem available from the Admin SDK. Please could you add support for these types of IDPs.

Describe the solution you'd like
Similar to being able to manage SAML and OIDC providers, please add into the SDK methods for managing default supported idp configs.

Describe alternatives you've considered
Calling the REST/gRPC APIs separately but this involves having to handle all the API handling framework already being completed by the Admin SDK.

@google-oss-bot
Copy link

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@bojeil-google
Copy link
Contributor

This is something we want to eventually support but will likely come later in the future.

@IainAdams
Copy link
Author

It seems like such an easy thing to add in as basically so similar to the existing OIDC and SAML features. I'll try and do a PR although I am currently having issues building v8.10.0 with Node v12.13.0 and npm 6.12.0. I know you say it supports v8.x + but have you tried building against Node v12?

@hiranya911
Copy link
Contributor

We have some tests that won't build/run on Node 12 (see #739). So you cannot currently develop on Node 12.

Also, we cannot accept any PRs for this functionality until the Firebase Auth team decides to officially support it in the SDK. According to the comment by @bojeil-google it appears they are still thinking about it. Therefore before you invest time into implementing any new code, I'd advise you to submit a feature request at https://firebase.google.com/support so that the Auth team can prioritize this accordingly.

@IchordeDionysos
Copy link
Contributor

@lahirumaramba is there any news on the support for this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants