Adds scrypt support in node 12 #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiranya911
approved these changes
Dec 23, 2019
|
Node 8's end of life is December 31, 2019. I guess the earliest business day we can merge is 1/2/2020. Or do you prefer some time later that month? |
|
Gcloud (Firestore, Storage etc) has a plan to drop Node8 support sometime in mid January. Let's align with their timetable. |
|
Firestore already dropped support for Node 8. See #921 |
Replaces scrypt npm module (no longer maintained and doesn't work for node 12) for testing standard scrypt with `crypto.scryptSync` which has been supported since node v10.5.
|
It's taken a while, but we are finally ready to drop Node 8 support. @bojeil-google I've rebased your branch against latest master, and updated the GitHub Actions configs to drop Node 8 support. Can I ask you to take a quick look? |
|
Related to #921 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces scrypt npm module (no longer maintained and
doesn't work for node 12) for testing standard scrypt with
crypto.scryptSyncwhich has been supported since node v10.5.