Skip to content

Commit

Permalink
Adds scrypt support in node 12 (#739)
Browse files Browse the repository at this point in the history
* Adds scrypt support in node 12

Replaces scrypt npm module (no longer maintained and
doesn't work for node 12) for testing standard scrypt with
`crypto.scryptSync` which has been supported since node v10.5.

* Fixes http timeout issues in node 12.

* Updated CI config; Re-generated the package lock file

Co-authored-by: hiranya911 <hiranya911@gmail.com>
  • Loading branch information
bojeil-google and hiranya911 authored Jul 8, 2020
1 parent c93893b commit db8be26
Show file tree
Hide file tree
Showing 8 changed files with 727 additions and 879 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:

strategy:
matrix:
node-version: [8.x, 10.x]
node-version: [10.x]

steps:
- uses: actions/checkout@v1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v1
with:
node-version: 8.x
node-version: 10.x

- name: Install and build
run: |
Expand Down Expand Up @@ -112,7 +112,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v1
with:
node-version: 8.x
node-version: 10.x

- name: Publish preflight check
id: preflight
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ information on using pull requests.

### Prerequisites

1. Node.js 8.13.0 or higher.
1. Node.js 10.10.0 or higher.
2. NPM 5 or higher (NPM 6 recommended).
3. Google Cloud SDK ([`gcloud`](https://cloud.google.com/sdk/downloads) utility)

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ requests, code review feedback, and also pull requests.

## Supported Environments

We support Node.js 8.13.0 and higher.
We support Node.js 10.10.0 and higher.

Please also note that the Admin SDK should only
be used in server-side/back-end environments controlled by the app developer.
Expand Down
Loading

0 comments on commit db8be26

Please sign in to comment.