change: Dropped Node 8 support and upgraded Firestore/Storage dependencies #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
approved these changes
Jul 8, 2020
package.json
Outdated
| @@ -61,15 +61,15 @@ | |||
| "node-forge": "^0.7.6" | |||
| }, | |||
| "optionalDependencies": { | |||
| "@google-cloud/firestore": "^3.0.0", | |||
| "@google-cloud/firestore": "^4.0.0", | |||
| "@google-cloud/storage": "^4.1.2" | |||
There was a problem hiding this comment.
Please update to 5.x as well.
|
Engines field was updated in #739 |
hiranya911
changed the title
sk-
reviewed
Jul 9, 2020
| @@ -61,15 +61,15 @@ | |||
| "node-forge": "^0.7.6" | |||
There was a problem hiding this comment.
@hiranya911 Given that you are already updating the dependencies, could you update this one to 0.9.1. Given that it is a 0.x version, npm considers it to be a breaking change, and hence not compatible with the current requirement.
node-forge is also transitively being used by firestore (direct dependency is google-p12-pem), and requiring version ^0.9.0, which means two copies of the library are currently needed. Switching to just one dependency would save 1.7Mib.
|
Good point @sk-. I'll send a separate PR for that. Feel free to beat me to it :) |
sk-
pushed a commit
to sk-/firebase-admin-node
that referenced
this pull request
Jul 10, 2020
As commnented on firebase#934 (comment) Given that node-forge is a 0.x version, npm considers it to be a breaking change, and hence not compatible with the current requirement. node-forge is also transitively being used by firestore (direct dependency is google-p12-pem), and requiring version ^0.9.0, which means two copies of the library are currently needed. Switching to just one dependency would save 1.7Mib.
hiranya911
pushed a commit
that referenced
this pull request
Jul 10, 2020
As commnented on #934 (comment) Given that node-forge is a 0.x version, npm considers it to be a breaking change, and hence not compatible with the current requirement. node-forge is also transitively being used by firestore (direct dependency is google-p12-pem), and requiring version ^0.9.0, which means two copies of the library are currently needed. Switching to just one dependency would save 1.7Mib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on top of #739 this PR:
@google-cloud/firestoreto latest major version.API CHANGE: Admin SDK now requires Node.js 10 or higher. Node.js 8 support has been terminated.
API CHANGE: Upgraded dependency on the
@google-cloud/firestorepackage to v4.API CHANGE: Upgraded dependency on the
@google-cloud/storagepackage to v5.Resolves #934