Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): reCAPTCHA Public preview #2129

Merged
merged 10 commits into from
Apr 12, 2023
Merged

feat(auth): reCAPTCHA Public preview #2129

merged 10 commits into from
Apr 12, 2023

Conversation

Xiaoshouzi-gh
Copy link
Contributor

@Xiaoshouzi-gh Xiaoshouzi-gh commented Mar 30, 2023

This is a rebased branch against master with recaptcha features.
The changes has all been previously reviewed and approved.

This is the branch we will merge once we are ready for release.

RELEASE NOTE: Added reCAPTCHA configuration support.

@Xiaoshouzi-gh Xiaoshouzi-gh added the release:stage Stage a release candidate label Mar 30, 2023
@Xiaoshouzi-gh Xiaoshouzi-gh marked this pull request as ready for review March 31, 2023 17:21
Copy link
Contributor

@pragatimodi pragatimodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some nits, feel free to ignore!
LGTM

src/auth/project-config.ts Outdated Show resolved Hide resolved
src/auth/project-config.ts Outdated Show resolved Hide resolved
src/auth/project-config.ts Outdated Show resolved Hide resolved
test/integration/auth.spec.ts Outdated Show resolved Hide resolved
test/integration/auth.spec.ts Outdated Show resolved Hide resolved
test/integration/auth.spec.ts Outdated Show resolved Hide resolved
test/integration/auth.spec.ts Outdated Show resolved Hide resolved
@Xiaoshouzi-gh
Copy link
Contributor Author

cc @prameshj @renkelvin

@lahirumaramba lahirumaramba changed the title reCAPTCHA Public preview feat(auth): reCAPTCHA Public preview Apr 4, 2023
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!
I think we got all the reference docs reviewed in the previous PRs.

/**
* The key's platform type: only web is currently supported.
*/
export type RecaptchaKeyClientType = 'WEB';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually support ANDROID and IOS too..

Does this mean the config returned will not show the mobile platform keys?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! We do return all 3 keys since we don't validate the key response. I think only web was supported at the time. Updated with all 3 type in the new commit.

Xiaoshouzi-gh and others added 10 commits April 12, 2023 15:26
* Defined reCAPTCHA config.
 - Added reCAPTCHA protection states.
 - Added reCAPTCHA action rule.
 - Added reCAPTCHA key config.
* Support reCaptcha config /create update on tenants.
 - Support create and update tenants with reCaptcha config.
 - Added reCaptcha unit tests on tenants operations.
* Recaptcha config changes in project config.
- Implemented getProjectConfig.
- Implemented updateProjectConfig.
- Updated error code.
- Add Term of Service consents.
* Added integ test for Project Config and Tenants update on reCAPTCHA config
* Support use_account_defender add-on feature for reCAPTCHA config.
* Added integration test for account defender feature
- Fix merge conflicts with sms region change
- Do not throw exceptions enabling account defender when recaptcha is OFF
Co-authored-by: pragatimodi <110490169+pragatimodi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:stage Stage a release candidate release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants