-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): reCAPTCHA Public preview #2129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some nits, feel free to ignore!
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM!
I think we got all the reference docs reviewed in the previous PRs.
src/auth/auth-config.ts
Outdated
/** | ||
* The key's platform type: only web is currently supported. | ||
*/ | ||
export type RecaptchaKeyClientType = 'WEB'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually support ANDROID and IOS too..
Does this mean the config returned will not show the mobile platform keys?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! We do return all 3 keys since we don't validate the key response. I think only web was supported at the time. Updated with all 3 type in the new commit.
2e127f3
to
938f9a0
Compare
* Defined reCAPTCHA config. - Added reCAPTCHA protection states. - Added reCAPTCHA action rule. - Added reCAPTCHA key config.
* Support reCaptcha config /create update on tenants. - Support create and update tenants with reCaptcha config. - Added reCaptcha unit tests on tenants operations.
* Recaptcha config changes in project config. - Implemented getProjectConfig. - Implemented updateProjectConfig. - Updated error code. - Add Term of Service consents.
* Added integ test for Project Config and Tenants update on reCAPTCHA config
* Support use_account_defender add-on feature for reCAPTCHA config. * Added integration test for account defender feature
- Fix merge conflicts with sms region change - Do not throw exceptions enabling account defender when recaptcha is OFF
Co-authored-by: pragatimodi <110490169+pragatimodi@users.noreply.github.com>
938f9a0
to
ca3c818
Compare
This reverts commit 0bf7d29.
This is a rebased branch against master with recaptcha features.
The changes has all been previously reviewed and approved.
This is the branch we will merge once we are ready for release.
RELEASE NOTE: Added reCAPTCHA configuration support.