Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appcheck): Added replay protection feature to App Check
verifyToken()
API #2148feat(appcheck): Added replay protection feature to App Check
verifyToken()
API #2148Changes from all commits
9fb78da
a7013e5
3de33f7
06f0ec3
1b9465b
26fa473
ebc64a7
56a0b98
b893a31
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Just for informational purposes, no action needed.) Right now the backend has two main error conditions (in this order of priority):
safety_net
, an HTTP 400 Bad Request will be returned. (Maybe we could even detect this early and avoid the network call?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good point! Since we check the validity of the token prior to making the call to BE, 1) should be addressed already. How do we check 2)?, is it a custom claim encoded in the JWT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For (2), yes, it is actually a private claim named
provider
in the JWT, but now that I think about this more, I think a more robust method for detecting whether the token supports Replay Protection is to see whether itsjti
claim is populated with a nonempty string rather than checking theprovider
claim against a hardcoded list of allowed providers.