Remove SSRC async initializer #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahirumaramba
approved these changes
Mar 5, 2024
| await template.load(); | ||
| return template; | ||
| } | ||
|
|
There was a problem hiding this comment.
do we need to update the internal API proposals to reflect this change?
There was a problem hiding this comment.
I was thinking this is a subset of the approved API, ie I'm not adding an unreviewed method, so it wasn't worth a full amendment, but I'll add a note to the doc, comment-in the approvers and see if they have any objections.
There was a problem hiding this comment.
Amendment approved!
jenh
approved these changes
Mar 6, 2024
erikeldridge
added a commit
that referenced
this pull request
Mar 7, 2024
This reverts commit 711dd17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a method intended as a convenience, which turned out to be inconvenient.
PR #2458 defined an async convenience method
getServerTemplate. In practice, we find the sync alternativeinitServerTemplatemuch more user-friendly and use it exclusively, so this PR removesgetServerTemplate.Discussion
Working with @lahirumaramba and @trekforever.
Testing
Ran npm test and all tests pass.
Functionally tested using a local server.