Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defines Auth multi-tenancy references in index.d.ts. #572

Merged
merged 3 commits into from
Jun 21, 2019

Conversation

bojeil-google
Copy link
Contributor

Defines Auth multi-tenancy references in index.d.ts.

src/index.d.ts Outdated Show resolved Hide resolved
src/index.d.ts Outdated Show resolved Hide resolved
src/index.d.ts Outdated
* A tenant configuration provides information such as the type of tenant (lightweight or
* full service), display name, tenant identifier and email authentication configuration.
* For OIDC/SAML provider configuration management, `TenantAwareAuth` instances should
* be used instead. When configuring these providers, note that tenants will inherit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of what?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it.

src/index.d.ts Outdated

/**
* The current tenant type: `lightweight` or `full_service`.
* Tenants that use separare billing and quota will require their own project and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/index.d.ts Outdated

/**
* Creates a new tenant.
* When creating new tenants, tenants that use separare billing and quota will require their
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

separate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/index.d.ts Outdated
@@ -602,6 +602,10 @@ declare namespace admin.auth {
* resets, password or email updates, etc).
*/
tokensValidAfterTime?: string;

/**
* The user's tenant identifier if available.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ID of the tenant the user belongs to

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/index.d.ts Outdated
@@ -727,6 +731,10 @@ declare namespace admin.auth {
* `"google.com"`, `"twitter.com"`, or `"custom"`.
*/
sign_in_provider: string;

/**
* The user's tenant ID if available.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/index.d.ts Outdated
interface Tenant {

/**
* The current tenant identifier.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you omit "current" here and throughout?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/index.d.ts Outdated
passwordRequired?: boolean;
};
}

/**
* Interface representing the properties to set on a new tenant to be created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... a new tenant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/index.d.ts Outdated
@@ -1820,18 +1933,101 @@ declare namespace admin.auth {
): Promise<admin.auth.AuthProviderConfig>;
}

/**
* Tenant aware `Auth` interface used for managing user, configuring SAML/OIDC providers,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tenant-aware

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/index.d.ts Outdated
@@ -1820,18 +1933,101 @@ declare namespace admin.auth {
): Promise<admin.auth.AuthProviderConfig>;
}

/**
* Tenant aware `Auth` interface used for managing user, configuring SAML/OIDC providers,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

users

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@bojeil-google bojeil-google merged commit 6158b1f into auth-multi-tenancy Jun 21, 2019
@bojeil-google bojeil-google deleted the multi-tenancy-references branch June 25, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants