fix(auth): Defines missing DecodedIdToken types.
#852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiranya911
changed the title
DecodedIdToken types.DecodedIdToken types.
hiranya911
approved these changes
Apr 17, 2020
egilmorez
reviewed
Apr 17, 2020
src/auth.d.ts
Outdated
| @@ -420,6 +420,17 @@ export namespace admin.auth { | |||
| */ | |||
| auth_time: number; | |||
|
|
|||
| /** | |||
| * The email corresponding to the user who the ID token belonged to, if available. | |||
There was a problem hiding this comment.
The email of the user to whom the ID token belonged, if available.
src/auth.d.ts
Outdated
| email?: string; | ||
|
|
||
| /** | ||
| * Whether the email corresponding to the user who the ID token belonged to is |
There was a problem hiding this comment.
Suggest "Whether or not the email of the user to whom the ID token belonged is verified, provided the user has an email."
Are the valid values true and false?
There was a problem hiding this comment.
Yes, true or false. Done.
src/auth.d.ts
Outdated
| @@ -494,6 +505,18 @@ export namespace admin.auth { | |||
| */ | |||
| iss: string; | |||
|
|
|||
| /** | |||
| * The phone number corresponding to the user who the ID token belonged to, | |||
There was a problem hiding this comment.
Suggest "The phone number of the user to whom the ID token belonged, if available."
Or -- can these be present tense "belongs?" That would be preferable if it is accurate.
There was a problem hiding this comment.
Done on both.
src/auth.d.ts
Outdated
| phone_number?: string; | ||
|
|
||
| /** | ||
| * The photo URL corresponding to the user who the ID token belonged to, |
There was a problem hiding this comment.
Suggest "The photo URL for the user to whom the ID token belonged..."
egilmorez
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #846
RELEASE NOTE: Exposed
email,email_verified,phone_numberandpicturefields from theDecodedIdTokentype.