Skip to content

Firebase ML: fixed displayName and tags regexes to match changed req. #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2020
Merged

Firebase ML: fixed displayName and tags regexes to match changed req. #459

merged 1 commit into from
May 8, 2020

Conversation

ifielker
Copy link
Contributor

@ifielker ifielker commented May 8, 2020

Firebase ML: fixed displayName and tags regexes to match changed backend requirements.

hiranya911
hiranya911 approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hiranya911 hiranya911 assigned ifielker and unassigned hiranya911 May 8, 2020
@ifielker ifielker merged commit 96b82c0 into master May 8, 2020
@ifielker ifielker deleted the fixRegex branch May 8, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@hiranya911 hiranya911 hiranya911 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ifielker ifielker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ifielker @hiranya911