Skip to content

fix(auth): Setting httpTimeout on certificate fetch requests #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2021
Merged

fix(auth): Setting httpTimeout on certificate fetch requests #538

merged 2 commits into from
Mar 25, 2021

Conversation

hiranya911
Copy link
Contributor

Passing the httpTimeout option to the request instance used to fetch public key certificates by verify_id_token() and verify_session_cookie() APIs.

Resolves #535

lahirumaramba
lahirumaramba approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hiranya911 hiranya911 merged commit 5e88d92 into master Mar 25, 2021
@hiranya911 hiranya911 deleted the hkj-cert-timeout branch March 25, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auth call timeout option
2 participants
@hiranya911 @lahirumaramba