Port spec test changes from firebase/firebase-js-sdk#7229 (Optimize l…

…ocal cache sync when resuming a query that had docs deleted)
firebase · Apr 24, 2023 · 0f870e9 · 0f870e9
1 parent c76b67c
commit 0f870e9
Show file tree

Hide file tree

Showing 8 changed files with 7,643 additions and 773 deletions.
diff --git a/firebase-firestore/src/test/java/com/google/firebase/firestore/spec/SpecTestCase.java b/firebase-firestore/src/test/java/com/google/firebase/firestore/spec/SpecTestCase.java
@@ -420,6 +420,22 @@ private Query parseQuery(Object querySpec) throws JSONException {
     }
   }
 
+  private static QueryPurpose parseQueryPurpose(Object value) {
+    if (!(value instanceof Integer)) {
+      throw new IllegalArgumentException("invalid query purpose: " + value);
+    }
+    switch ((Integer) value) {
+      case 0:
+        return QueryPurpose.LISTEN;
+      case 1:
+        return QueryPurpose.EXISTENCE_FILTER_MISMATCH;
+      case 3:
+        return QueryPurpose.LIMBO_RESOLUTION;
+      default:
+        throw new IllegalArgumentException("unknown query purpose value: " + value);
+    }
+  }
+
   private DocumentViewChange parseChange(JSONObject jsonDoc, DocumentViewChange.Type type)
       throws JSONException {
     long version = jsonDoc.getLong("version");
@@ -1027,7 +1043,7 @@ private void validateExpectedState(@Nullable JSONObject expectedState) throws JS
 
             QueryPurpose purpose = QueryPurpose.LISTEN;
             if (queryDataJson.has("targetPurpose")) {
-              purpose = QueryPurpose.values()[queryDataJson.getInt("targetPurpose")];
+              purpose = parseQueryPurpose(queryDataJson.get("targetPurpose"));
             }
 
             TargetData targetData =

diff --git a/firebase-firestore/src/test/resources/json/bundle_spec_test.json b/firebase-firestore/src/test/resources/json/bundle_spec_test.json
@@ -1179,7 +1179,7 @@
                 }
               ],
               "resumeToken": "",
-              "targetPurpose": 2
+              "targetPurpose": 3
             },
             "2": {
               "queries": [