Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp test harness for macrobenchmark tests #4071

Merged
merged 13 commits into from
Sep 20, 2022

Conversation

yifanyang
Copy link
Contributor

  • Upgrade Gradle version to 7.5.1
  • Upgrade Android Gradle plugin version to 7.2.2
  • Support trace collection for custom event
  • Support building and running tests manually

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Unit Test Results

   394 files  ±0     394 suites  ±0   18m 36s ⏱️ - 30m 33s
4 713 tests  - 4  4 691 ✔️ +29  22 💤 ±0  0  - 33 
4 729 runs   - 4  4 707 ✔️ +29  22 💤 ±0  0  - 33 

Results for commit fb143af. ± Comparison against base commit 005fc6b.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 9, 2022

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.22% (65356d8) to 50.21% (1b84bbf) by -0.01%.

    FilenameBase (65356d8)Merge (1b84bbf)Diff
    WriteTree.java77.22%76.67%-0.56%
  • firebase-firestore

    Overall coverage changed from 44.25% (65356d8) to 44.25% (1b84bbf) by +0.01%.

    FilenameBase (65356d8)Merge (1b84bbf)Diff
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java94.44%97.22%+2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5LopebMyON.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 9, 2022

Comment on lines 104 to 105
# Adding an empty android app for baseline comparison
config['test-apps'].insert(0, {'sdk': 'baseline', 'name': 'baseline'})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are now measuring Firebase traces only, do we still need this baseline to be present?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Removed it and the reference to it in the README.

@yifanyang yifanyang merged commit 523730a into master Sep 20, 2022
@yifanyang yifanyang deleted the yifany/macrobenchmark-tracing branch September 20, 2022 17:00
@firebase firebase locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants