-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp test harness for macrobenchmark tests #4071
Conversation
yifanyang
commented
Sep 9, 2022
- Upgrade Gradle version to 7.5.1
- Upgrade Android Gradle plugin version to 7.2.2
- Support trace collection for custom event
- Support building and running tests manually
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected ProductsNo changes between base commit (65356d8) and merge commit (1b84bbf).Test Logs |
# Adding an empty android app for baseline comparison | ||
config['test-apps'].insert(0, {'sdk': 'baseline', 'name': 'baseline'}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are now measuring Firebase traces only, do we still need this baseline to be present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Removed it and the reference to it in the README.