Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Documentation classpath #4099

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Fix Documentation classpath #4099

merged 1 commit into from
Sep 19, 2022

Conversation

vkryachko
Copy link
Member

b/241795594

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject encoders_firebase-encoders-proto:
error: Class com.google.firebase.encoders.proto.ProtobufEncoder.Builder no longer implements com.google.firebase.encoders.config.EncoderConfig<com.google.firebase.encoders.proto.ProtobufEncoder.Builder> [RemovedInterface]
error: Removed method com.google.firebase.encoders.proto.ProtobufEncoder.Builder.configureWith(com.google.firebase.encoders.config.Configurator) [RemovedMethod]
error: Removed method com.google.firebase.encoders.proto.ProtobufEncoder.Builder.registerEncoder(Class,com.google.firebase.encoders.ObjectEncoder<? super U>) [RemovedMethod]
error: Removed method com.google.firebase.encoders.proto.ProtobufEncoder.Builder.registerEncoder(Class,com.google.firebase.encoders.ValueEncoder<? super U>) [RemovedMethod]
error: Removed method com.google.firebase.encoders.proto.ProtobufEncoder.Builder.registerFallbackEncoder(com.google.firebase.encoders.ObjectEncoder) [RemovedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 15, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2022

Unit Test Results

   394 files  +1     394 suites  +1   18m 18s ⏱️ -19s
4 717 tests +6  4 693 ✔️ +6  22 💤 ±0  2 ±0 
4 733 runs  +6  4 709 ✔️ +6  22 💤 ±0  2 ±0 

For more details on these failures, see this check.

Results for commit c33d29e. ± Comparison against base commit 6bc2882.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 15, 2022

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.21% (6bc2882) to 50.17% (2b12170) by -0.04%.

    FilenameBase (6bc2882)Merge (2b12170)Diff
    WebsocketConnection.java35.03%32.77%-2.26%
  • firebase-firestore

    Overall coverage changed from 44.25% (6bc2882) to 44.25% (2b12170) by +0.00%.

    FilenameBase (6bc2882)Merge (2b12170)Diff
    PatchMutation.java98.39%100.00%+1.61%
  • firebase-messaging

    Overall coverage changed from 85.26% (6bc2882) to 85.30% (2b12170) by +0.04%.

    FilenameBase (6bc2882)Merge (2b12170)Diff
    FirebaseMessaging.java76.21%75.33%-0.88%
    Metadata.java57.14%61.90%+4.76%
  • firebase-storage

    Overall coverage changed from 85.94% (6bc2882) to 86.24% (2b12170) by +0.30%.

    FilenameBase (6bc2882)Merge (2b12170)Diff
    StorageException.java65.45%69.09%+3.64%
    StorageTask.java84.59%84.89%+0.30%
    UploadTask.java80.58%82.01%+1.44%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qQxZ4MWdPc.html

@github-actions
Copy link
Contributor

buildSrc Test Results

18 tests  ±0   18 ✔️ ±0   2m 39s ⏱️ -28s
  4 suites ±0     0 💤 ±0 
  4 files   ±0     0 ±0 

Results for commit c33d29e. ± Comparison against base commit 6bc2882.

Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@vkryachko vkryachko merged commit 607dafc into master Sep 19, 2022
@vkryachko vkryachko deleted the vk.fix_doc_classpath branch September 19, 2022 12:52
qdpham13 pushed a commit that referenced this pull request Sep 20, 2022
@firebase firebase locked and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants