Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendor plugin to use non-deprecated api #5179

Merged
merged 8 commits into from
Jul 19, 2023
Merged

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jul 18, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-inappmessaging-display
### {{inappmessaging}} Display version 20.3.3 {: #inappmessaging-display_v20-3-3}

* {{unchanged}} Updated internal Dagger dependency.

#### {{inappmessaging}} Display Kotlin extensions version 20.3.3 {: #inappmessaging-display-ktx_v20-3-3}

The Kotlin extensions library transitively includes the updated
`firebase-inappmessaging-display` library. The Kotlin extensions library has no additional
updates.
firebase-inappmessaging
### {{inappmessaging}} version 20.3.3 {: #inappmessaging_v20-3-3}

* {{unchanged}} Updated internal Dagger dependency.

#### {{inappmessaging}} Kotlin extensions version 20.3.3 {: #inappmessaging-ktx_v20-3-3}

The Kotlin extensions library transitively includes the updated
`firebase-inappmessaging` library. The Kotlin extensions library has no additional
updates.
firebase-ml-modeldownloader
### {{firebase_ml}} version 24.1.3 {: #firebaseml-modeldownloader_v24-1-3}

* {{unchanged}} Updated internal Dagger dependency.

* {{fixed}} Updated the third-party license file to include Dagger's license.

#### {{firebase_ml}} Kotlin extensions version 24.1.3 {: #firebaseml-modeldownloader-ktx_v24-1-3}

The Kotlin extensions library transitively includes the updated
`firebase-ml-modeldownloader` library. The Kotlin extensions library has no additional
updates.

The following had changelogs that were modified, but did not have any unreleased entries for release notes to generate from.

Changelogs

transport:transport-runtime

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

buildSrc Test Results

28 tests   28 ✔️  1m 12s ⏱️
  6 suites    0 💤
  6 files      0

Results for commit 3e76a6d.

♻️ This comment has been updated with latest results.

@rlazo rlazo marked this pull request as ready for review July 18, 2023 22:27
@rlazo rlazo requested review from daymxn and VinayGuthal July 18, 2023 22:27
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

Unit Test Results

   818 files  +   756     818 suites  +756   38m 51s ⏱️ + 35m 53s
4 956 tests +4 616  4 935 ✔️ +4 595  21 💤 +21  0 ±0 
9 821 runs  +9 141  9 779 ✔️ +9 099  42 💤 +42  0 ±0 

Results for commit 3e76a6d. ± Comparison against base commit 3fcf343.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 18, 2023

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (3fcf343)Merge (0f8491d)Diff
    aar251 kB251 kB+14 B (+0.0%)
  • firebase-crashlytics

    TypeBase (3fcf343)Merge (0f8491d)Diff
    apk (aggressive)432 kB432 kB-80 B (-0.0%)
    apk (release)2.17 MB2.17 MB-6.87 kB (-0.3%)
  • firebase-crashlytics-ktx

    TypeBase (3fcf343)Merge (0f8491d)Diff
    apk (aggressive)433 kB433 kB+12 B (+0.0%)
    apk (release)2.17 MB2.17 MB-6.25 kB (-0.3%)
  • firebase-crashlytics-ndk

    TypeBase (3fcf343)Merge (0f8491d)Diff
    apk (release / arm64-v8a)3.34 MB3.33 MB-4.10 kB (-0.1%)
    apk (release / armeabi-v7a)2.81 MB2.81 MB-4.10 kB (-0.1%)
    apk (release / x86)3.32 MB3.32 MB-4.10 kB (-0.1%)
    apk (release / x86_64)3.38 MB3.38 MB-4.10 kB (-0.1%)
  • firebase-functions

    TypeBase (3fcf343)Merge (0f8491d)Diff
    aar47.1 kB47.1 kB+48 B (+0.1%)
  • firebase-inappmessaging

    TypeBase (3fcf343)Merge (0f8491d)Diff
    aar453 kB458 kB+4.82 kB (+1.1%)
    apk (aggressive)700 kB700 kB+36 B (+0.0%)
    apk (release)3.95 MB3.95 MB-196 B (-0.0%)
  • firebase-inappmessaging-display

    TypeBase (3fcf343)Merge (0f8491d)Diff
    aar179 kB182 kB+3.54 kB (+2.0%)
    apk (aggressive)1.53 MB1.53 MB-132 B (-0.0%)
    apk (release)5.21 MB5.21 MB+240 B (+0.0%)
  • firebase-inappmessaging-display-ktx

    TypeBase (3fcf343)Merge (0f8491d)Diff
    apk (aggressive)1.54 MB1.54 MB-16 B (-0.0%)
    apk (release)5.59 MB5.59 MB+92 B (+0.0%)
  • firebase-inappmessaging-ktx

    TypeBase (3fcf343)Merge (0f8491d)Diff
    apk (release)4.33 MB4.33 MB+96 B (+0.0%)
  • firebase-ml-modeldownloader

    TypeBase (3fcf343)Merge (0f8491d)Diff
    aar122 kB122 kB-247 B (-0.2%)
  • firebase-perf

    TypeBase (3fcf343)Merge (0f8491d)Diff
    apk (aggressive)1.24 MB1.24 MB-40 B (-0.0%)
    apk (release)3.74 MB3.73 MB-5.22 kB (-0.1%)
  • firebase-perf-ktx

    TypeBase (3fcf343)Merge (0f8491d)Diff
    apk (aggressive)1.24 MB1.24 MB-24 B (-0.0%)
    apk (release)3.75 MB3.74 MB-5.59 kB (-0.1%)
  • firebase-sessions

    TypeBase (3fcf343)Merge (0f8491d)Diff
    apk (aggressive)364 kB364 kB-48 B (-0.0%)
    apk (release)2.06 MB2.06 MB-4.87 kB (-0.2%)
  • transport-runtime

    TypeBase (3fcf343)Merge (0f8491d)Diff
    aar180 kB160 kB-20.3 kB (-11.3%)
    apk (aggressive)44.6 kB44.6 kB+24 B (+0.1%)
    apk (release)84.1 kB79.1 kB-4.98 kB (-5.9%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/korlF0CAVC.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 18, 2023

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from 0.00% (3fcf343) to 75.99% (0f8491d) by +75.99%.

    46 individual files with coverage change

    FilenameBase (3fcf343)Merge (0f8491d)Diff
    AabUpdater.java0.00%98.36%+98.36%
    ApkInstaller.java0.00%100.00%+100.00%
    ApkUpdater.java0.00%92.63%+92.63%
    AppDistributionReleaseImpl.java0.00%100.00%+100.00%
    AppDistributionReleaseInternal.java0.00%100.00%+100.00%
    AppIconSource.java0.00%84.62%+84.62%
    AppIconSource_Factory.java0.00%100.00%+100.00%
    AutoValue_AppDistributionReleaseImpl.java0.00%65.45%+65.45%
    AutoValue_AppDistributionReleaseInternal.java0.00%71.58%+71.58%
    AutoValue_ImageUtils_ImageSize.java0.00%35.00%+35.00%
    AutoValue_TesterApiDisabledErrorDetails.java0.00%29.41%+29.41%
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java0.00%54.17%+54.17%
    AutoValue_UpdateProgressImpl.java0.00%65.96%+65.96%
    DaggerAppDistroComponent.java0.00%80.56%+80.56%
    DevModeDetector.java0.00%9.09%+9.09%
    DevModeDetector_Factory.java0.00%100.00%+100.00%
    FeedbackActivity.java0.00%3.39%+3.39%
    FeedbackSender.java0.00%84.48%+84.48%
    FeedbackTrigger.java0.00%61.54%+61.54%
    FirebaseAppDistributionExceptions.java0.00%80.00%+80.00%
    FirebaseAppDistributionImpl.java0.00%89.89%+89.89%
    FirebaseAppDistributionLifecycleNotifier.java0.00%91.49%+91.49%
    FirebaseAppDistributionNotificationsManager.java0.00%88.89%+88.89%
    FirebaseAppDistributionRegistrar.java0.00%95.83%+95.83%
    FirebaseAppDistributionTesterApiClient.java0.00%88.78%+88.78%
    HttpsUrlConnectionFactory.java0.00%50.00%+50.00%
    HttpsUrlConnectionFactory_Factory.java0.00%100.00%+100.00%
    ImageUtils.java0.00%100.00%+100.00%
    InstallActivity.java0.00%2.67%+2.67%
    LogWrapper.java0.00%86.67%+86.67%
    NewReleaseFetcher.java0.00%86.67%+86.67%
    PackageInfoUtils.java0.00%42.86%+42.86%
    ReleaseIdentifier.java0.00%91.78%+91.78%
    ReleaseUtils.java0.00%83.33%+83.33%
    ScreenshotTaker.java0.00%36.17%+36.17%
    SequentialReference.java0.00%100.00%+100.00%
    SignInStorage.java0.00%100.00%+100.00%
    TaskCache.java0.00%100.00%+100.00%
    TaskCompletionSourceCache.java0.00%72.41%+72.41%
    TaskUtils.java0.00%77.50%+77.50%
    TesterApiDisabledErrorDetails.java0.00%93.75%+93.75%
    TesterApiHttpClient.java0.00%90.09%+90.09%
    TesterSignInManager.java0.00%95.45%+95.45%
    UpdateProgressImpl.java0.00%100.00%+100.00%
    UpdateTaskCache.java0.00%91.30%+91.30%
    UpdateTaskImpl.java0.00%76.32%+76.32%

  • firebase-functions

    Overall coverage changed from 0.00% (3fcf343) to 3.22% (0f8491d) by +3.22%.

    FilenameBase (3fcf343)Merge (0f8491d)Diff
    FunctionsRegistrar.java0.00%61.54%+61.54%
  • firebase-inappmessaging

    Overall coverage changed from 0.00% (3fcf343) to 39.34% (0f8491d) by +39.34%.

    56 individual files with coverage change

    FilenameBase (3fcf343)Merge (0f8491d)Diff
    AbtIntegrationHelper.java0.00%60.87%+60.87%
    Action.java0.00%76.47%+76.47%
    AnalyticsEventsManager.java0.00%85.19%+85.19%
    ApiClient.java0.00%100.00%+100.00%
    AutoValue_InstallationIdResult.java0.00%33.33%+33.33%
    AutoValue_RateLimit.java0.00%53.19%+53.19%
    BannerMessage.java0.00%75.00%+75.00%
    Button.java0.00%61.76%+61.76%
    CampaignAnalytics.java0.00%33.22%+33.22%
    CampaignCacheClient.java0.00%88.00%+88.00%
    CampaignImpression.java0.00%38.96%+38.96%
    CampaignImpressionList.java0.00%39.25%+39.25%
    CampaignMetadata.java0.00%100.00%+100.00%
    CampaignProto.java0.00%27.48%+27.48%
    CardMessage.java0.00%78.48%+78.48%
    ClientAppInfo.java0.00%35.79%+35.79%
    CommonTypesProto.java0.00%9.96%+9.96%
    DataCollectionHelper.java0.00%87.50%+87.50%
    DeveloperListenerManager.java0.00%100.00%+100.00%
    DismissType.java0.00%82.61%+82.61%
    DisplayCallbacksFactory.java0.00%100.00%+100.00%
    DisplayCallbacksImpl.java0.00%93.46%+93.46%
    EventType.java0.00%76.19%+76.19%
    ExperimentPayloadProto.java0.00%6.05%+6.05%
    FetchEligibleCampaignsRequest.java0.00%32.97%+32.97%
    FetchEligibleCampaignsResponse.java0.00%42.86%+42.86%
    FetchErrorReason.java0.00%52.17%+52.17%
    FiamAnalyticsConnectorListener.java0.00%100.00%+100.00%
    FirebaseInAppMessaging.java0.00%80.60%+80.60%
    FirebaseInAppMessagingDisplayCallbacks.java0.00%100.00%+100.00%
    ForegroundNotifier.java0.00%76.00%+76.00%
    GrpcClient.java0.00%100.00%+100.00%
    ImageData.java0.00%71.43%+71.43%
    ImageOnlyMessage.java0.00%75.86%+75.86%
    ImpressionStorageClient.java0.00%100.00%+100.00%
    InAppMessage.java0.00%24.24%+24.24%
    InAppMessageStreamManager.java0.00%91.40%+91.40%
    InAppMessagingSdkServingGrpc.java0.00%51.22%+51.22%
    InstallationIdResult.java0.00%100.00%+100.00%
    MessagesProto.java0.00%36.13%+36.13%
    MessageType.java0.00%100.00%+100.00%
    MetricsLoggerClient.java0.00%94.29%+94.29%
    ModalMessage.java0.00%74.07%+74.07%
    ProtoMarshallerClient.java0.00%91.40%+91.40%
    ProtoStorageClient.java0.00%100.00%+100.00%
    ProviderInstaller.java0.00%37.50%+37.50%
    ProxyAnalyticsConnector.java0.00%67.95%+67.95%
    RateLimiterClient.java0.00%100.00%+100.00%
    RateLimitProto.java0.00%52.69%+52.69%
    RenderErrorReason.java0.00%82.61%+82.61%
    Schedulers.java0.00%87.50%+87.50%
    SharedPreferencesUtils.java0.00%40.35%+40.35%
    SystemClock.java0.00%100.00%+100.00%
    TestDeviceHelper.java0.00%100.00%+100.00%
    Text.java0.00%67.74%+67.74%
    TriggeredInAppMessage.java0.00%100.00%+100.00%

  • firebase-inappmessaging-display

    Overall coverage changed from 0.00% (3fcf343) to 35.17% (0f8491d) by +35.17%.

    20 individual files with coverage change

    FilenameBase (3fcf343)Merge (0f8491d)Diff
    BackButtonHandler.java0.00%33.33%+33.33%
    BannerBindingWrapper.java0.00%92.31%+92.31%
    BaseModalLayout.java0.00%10.67%+10.67%
    BindingWrapper.java0.00%80.00%+80.00%
    CardBindingWrapper.java0.00%6.06%+6.06%
    FiamAnimator.java0.00%11.63%+11.63%
    FiamFrameLayout.java0.00%28.57%+28.57%
    FiamImageLoader.java0.00%77.94%+77.94%
    FiamRelativeLayout.java0.00%28.57%+28.57%
    FiamWindowManager.java0.00%71.83%+71.83%
    FirebaseInAppMessagingDisplay.java0.00%87.98%+87.98%
    FirebaseInAppMessagingDisplayImpl.java0.00%43.75%+43.75%
    ImageBindingWrapper.java0.00%86.96%+86.96%
    InAppMessageLayoutConfig.java0.00%91.84%+91.84%
    InflaterConfigModule.java0.00%50.00%+50.00%
    ModalBindingWrapper.java0.00%83.33%+83.33%
    ModalLayoutPortrait.java0.00%4.29%+4.29%
    OnSwipeUpListener.java0.00%87.50%+87.50%
    ResizableImageView.java0.00%9.38%+9.38%
    VerticalViewGroupMeasure.java0.00%7.35%+7.35%

  • firebase-messaging

    Overall coverage changed from 84.14% (3fcf343) to 84.29% (0f8491d) by +0.15%.

    FilenameBase (3fcf343)Merge (0f8491d)Diff
    FirebaseMessaging.java73.57%73.13%-0.44%
    Metadata.java36.51%41.27%+4.76%
    RequestDeduplicator.java80.00%90.00%+10.00%
  • firebase-ml-modeldownloader

    Overall coverage changed from 0.00% (3fcf343) to 83.46% (0f8491d) by +83.46%.

    22 individual files with coverage change

    FilenameBase (3fcf343)Merge (0f8491d)Diff
    AutoFirebaseMlLogEventEncoder.java0.00%100.00%+100.00%
    AutoValue_FirebaseMlLogEvent.java0.00%58.18%+58.18%
    AutoValue_FirebaseMlLogEvent_DeleteModelLogEvent.java0.00%66.67%+66.67%
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent.java0.00%65.82%+65.82%
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent_ModelOptions.java0.00%62.96%+62.96%
    AutoValue_FirebaseMlLogEvent_ModelDownloadLogEvent_ModelOptions_ModelInfo.java0.00%64.58%+64.58%
    AutoValue_FirebaseMlLogEvent_SystemInfo.java0.00%63.38%+63.38%
    CustomModel.java0.00%72.13%+72.13%
    CustomModelDownloadConditions.java0.00%88.46%+88.46%
    CustomModelDownloadService.java0.00%79.89%+79.89%
    DaggerModelDownloaderComponent.java0.00%100.00%+100.00%
    DataTransportMlEventSender.java0.00%100.00%+100.00%
    DownloadType.java0.00%100.00%+100.00%
    FirebaseMlException.java0.00%100.00%+100.00%
    FirebaseMlLogEvent.java0.00%97.92%+97.92%
    FirebaseMlLogger.java0.00%88.89%+88.89%
    FirebaseModelDownloader.java0.00%84.66%+84.66%
    FirebaseModelDownloaderRegistrar.java0.00%100.00%+100.00%
    ModelDownloaderComponent.java0.00%25.00%+25.00%
    ModelFileDownloadService.java0.00%88.76%+88.76%
    ModelFileManager.java0.00%82.28%+82.28%
    SharedPreferencesUtil.java0.00%97.26%+97.26%

  • firebase-perf

    Overall coverage changed from 71.20% (3fcf343) to 71.19% (0f8491d) by -0.02%.

    FilenameBase (3fcf343)Merge (0f8491d)Diff
    RateLimiter.java91.54%90.77%-0.77%
  • firebase-storage

    Overall coverage changed from 85.73% (3fcf343) to 85.77% (0f8491d) by +0.04%.

    FilenameBase (3fcf343)Merge (0f8491d)Diff
    NetworkRequest.java86.60%87.11%+0.52%
  • transport-runtime

    Overall coverage changed from 0.00% (3fcf343) to 58.72% (0f8491d) by +58.72%.

    41 individual files with coverage change

    FilenameBase (3fcf343)Merge (0f8491d)Diff
    AlarmManagerScheduler.java0.00%90.48%+90.48%
    AlarmManagerSchedulerBroadcastReceiver.java0.00%6.25%+6.25%
    AutoProtoEncoderDoNotUseEncoder.java0.00%84.47%+84.47%
    AutoValue_BackendRequest.java0.00%60.00%+60.00%
    AutoValue_BackendResponse.java0.00%31.82%+31.82%
    AutoValue_CreationContext.java0.00%55.26%+55.26%
    AutoValue_EventInternal.java0.00%65.82%+65.82%
    AutoValue_EventStoreConfig.java0.00%56.06%+56.06%
    AutoValue_PersistedEvent.java0.00%55.17%+55.17%
    AutoValue_SchedulerConfig.java0.00%33.33%+33.33%
    AutoValue_SchedulerConfig_ConfigValue.java0.00%53.19%+53.19%
    AutoValue_SendRequest.java0.00%63.38%+63.38%
    AutoValue_TransportContext.java0.00%86.36%+86.36%
    BackendRequest.java0.00%100.00%+100.00%
    BackendResponse.java0.00%100.00%+100.00%
    ClientMetrics.java0.00%57.14%+57.14%
    CreationContext.java0.00%66.67%+66.67%
    CreationContextFactory.java0.00%100.00%+100.00%
    DefaultScheduler.java0.00%80.00%+80.00%
    EncodedPayload.java0.00%61.90%+61.90%
    EventInternal.java0.00%53.85%+53.85%
    EventStoreConfig.java0.00%100.00%+100.00%
    JobInfoScheduler.java0.00%95.83%+95.83%
    LogEventDropped.java0.00%40.00%+40.00%
    Logging.java0.00%47.06%+47.06%
    MetadataBackendRegistry.java0.00%66.67%+66.67%
    PersistedEvent.java0.00%100.00%+100.00%
    PriorityMapping.java0.00%88.89%+88.89%
    ProtoEncoderDoNotUse.java0.00%50.00%+50.00%
    SafeLoggingExecutor.java0.00%84.62%+84.62%
    SchedulerConfig.java0.00%98.46%+98.46%
    SchemaManager.java0.00%98.51%+98.51%
    SendRequest.java0.00%100.00%+100.00%
    SQLiteEventStore.java0.00%38.32%+38.32%
    TestClock.java0.00%40.00%+40.00%
    TransportContext.java0.00%69.23%+69.23%
    TransportFactoryImpl.java0.00%100.00%+100.00%
    TransportImpl.java0.00%84.21%+84.21%
    TransportRuntime.java0.00%59.26%+59.26%
    Uploader.java0.00%95.00%+95.00%
    UptimeClock.java0.00%100.00%+100.00%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/OHqY8PKlX0.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 18, 2023

Startup Time Report 1

The report is too large (122,580 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Ijr0mWovmr/index.html

@rlazo rlazo merged commit f15e429 into master Jul 19, 2023
@rlazo rlazo deleted the rl.vendir_update branch July 19, 2023 19:10
@firebase firebase locked and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants