Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update report to getRequired instead of deprecated alternative. #5182

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Update report to getRequired instead of deprecated alternative. #5182

merged 2 commits into from
Jul 20, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jul 20, 2023

No description provided.

@rlazo rlazo requested a review from daymxn July 20, 2023 21:35
@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023 •
edited
Loading

buildSrc Test Results

33 tests   33 ✔️  1m 19s ⏱️
  7 suites    0 💤
  7 files      0 ❌

Results for commit ee09b2d.

♻️ This comment has been updated with latest results.

@rlazo rlazo enabled auto-merge (squash) July 20, 2023 21:46
@github-actions
Copy link
Contributor

Unit Test Results

   802 files   -   16     802 suites   - 16   37m 59s ⏱️ +22s
4 956 tests ±    0  4 932 ✔️  -     3  21 💤 ±0  3 ❌ +3 
9 505 runs   - 316  9 461 ✔️  - 318  41 💤  - 1  3 ❌ +3 

For more details on these failures, see this check.

Results for commit 4619e3f. ± Comparison against base commit 79d24f0.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 20, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (933d191) and merge commit (0dba12b).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JwLPmTsAeQ.html

@rlazo rlazo merged commit dc08ef1 into master Jul 20, 2023
159 of 161 checks passed
@rlazo rlazo deleted the rl.report.deprecated branch July 20, 2023 22:23
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-messaging

    Overall coverage changed from 84.10% (933d191) to 84.21% (0dba12b) by +0.11%.

    FilenameBase (933d191)Merge (0dba12b)Diff
    FirebaseMessaging.java73.57%73.13%-0.44%
    MessagingAnalytics.java81.38%81.78%+0.40%
    Metadata.java36.51%41.27%+4.76%

  • firebase-perf

    Overall coverage changed from 71.20% (933d191) to 71.19% (0dba12b) by -0.02%.

    FilenameBase (933d191)Merge (0dba12b)Diff
    RateLimiter.java91.54%90.77%-0.77%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zobY1d2PfN.html

@firebase firebase locked and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daymxn daymxn daymxn approved these changes

Assignees
No one assigned
Labels
no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @daymxn