Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to ignore specific commits from the release generator. #5200

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Add support to ignore specific commits from the release generator. #5200

merged 2 commits into from
Jul 26, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jul 26, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions
Copy link
Contributor

buildSrc Test Results

33 tests   33 ✔️  1m 39s ⏱️
  7 suites    0 💤
  7 files      0 ❌

Results for commit d36d4c3.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023 •
edited
Loading

Unit Test Results

   818 files  +   778     818 suites  +778   38m 23s ⏱️ + 35m 56s
4 956 tests +4 757  4 935 ✔️ +4 737  21 💤 +20  0 ❌ ±0 
9 821 runs  +9 423  9 779 ✔️ +9 383  42 💤 +40  0 ❌ ±0 

Results for commit d36d4c3. ± Comparison against base commit fc5cde4.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (fc5cde4) and merge commit (015c8a5).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/M3fE1SwoYq.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.15% (fc5cde4) to 50.18% (015c8a5) by +0.02%.

    FilenameBase (fc5cde4)Merge (015c8a5)Diff
    DoubleNode.java88.24%100.00%+11.76%

  • firebase-firestore

    Overall coverage changed from 44.35% (fc5cde4) to 44.34% (015c8a5) by -0.00%.

    FilenameBase (fc5cde4)Merge (015c8a5)Diff
    SetMutation.java97.22%94.44%-2.78%

  • firebase-messaging

    Overall coverage changed from 84.10% (fc5cde4) to 84.14% (015c8a5) by +0.04%.

    FilenameBase (fc5cde4)Merge (015c8a5)Diff
    FirebaseMessaging.java73.13%72.69%-0.44%
    RequestDeduplicator.java80.00%90.00%+10.00%

  • firebase-perf

    Overall coverage changed from ? (fc5cde4) to 71.19% (015c8a5) by ?.

    103 individual files with coverage change

    FilenameBase (fc5cde4)Merge (015c8a5)Diff
    AddTrace.java?0.00%?
    AndroidApplicationInfo.java?34.71%?
    AndroidApplicationInfoOrBuilder.java?0.00%?
    AndroidLogger.java?100.00%?
    AndroidMemoryReading.java?38.36%?
    AndroidMemoryReadingOrBuilder.java?0.00%?
    ApplicationInfo.java?45.00%?
    ApplicationInfoOrBuilder.java?0.00%?
    ApplicationProcessState.java?73.91%?
    AppStartTrace.java?77.37%?
    AppStateMonitor.java?84.97%?
    AppStateUpdateHandler.java?89.29%?
    Clock.java?100.00%?
    ConfigResolver.java?93.43%?
    ConfigurationConstants.java?97.93%?
    ConfigurationFlag.java?80.00%?
    ConsoleUrlGenerator.java?37.50%?
    Constants.java?95.65%?
    Counter.java?90.91%?
    CpuGaugeCollector.java?92.77%?
    CpuMetricReading.java?39.33%?
    CpuMetricReadingOrBuilder.java?0.00%?
    DaggerFirebasePerformanceComponent.java?100.00%?
    DeviceCacheManager.java?76.42%?
    FirebasePerfApplicationInfoValidator.java?92.86%?
    FirebasePerfEarly.java?85.00%?
    FirebasePerfGaugeMetricValidator.java?100.00%?
    FirebasePerfHttpClient.java?93.85%?
    FirebasePerfMetricProto.java?0.00%?
    FirebasePerfNetworkValidator.java?86.67%?
    FirebasePerfOkHttpClient.java?44.90%?
    FirebasePerformance.java?79.12%?
    FirebasePerformanceAttributable.java?0.00%?
    FirebasePerformanceComponent.java?0.00%?
    FirebasePerformanceInitializer.java?33.33%?
    FirebasePerformanceModule.java?100.00%?
    FirebasePerformanceModule_ProvidesConfigResolverFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseAppFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesFirebaseInstallationsFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigComponentFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesRemoteConfigManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesSessionManagerFactory.java?100.00%?
    FirebasePerformanceModule_ProvidesTransportFactoryProviderFactory.java?100.00%?
    FirebasePerformance_Factory.java?100.00%?
    FirebasePerfRegistrar.java?100.00%?
    FirebasePerfTraceValidator.java?85.87%?
    FirebasePerfUrlConnection.java?44.26%?
    FirstDrawDoneListener.java?85.71%?
    FlgTransport.java?83.33%?
    FragmentStateMonitor.java?94.87%?
    FrameMetricsCalculator.java?96.77%?
    FrameMetricsRecorder.java?76.32%?
    GaugeManager.java?98.40%?
    GaugeMetadata.java?26.17%?
    GaugeMetadataManager.java?77.78%?
    GaugeMetadataOrBuilder.java?0.00%?
    GaugeMetric.java?39.47%?
    GaugeMetricOrBuilder.java?0.00%?
    HttpMetric.java?92.65%?
    ImmutableBundle.java?100.00%?
    InstrHttpInputStream.java?92.86%?
    InstrHttpOutputStream.java?98.00%?
    InstrHttpsURLConnection.java?94.32%?
    InstrHttpURLConnection.java?93.42%?
    InstrumentApacheHttpResponseHandler.java?100.00%?
    InstrumentOkHttpEnqueueCallback.java?100.00%?
    InstrURLConnectionBase.java?94.86%?
    LogWrapper.java?23.08%?
    MemoryGaugeCollector.java?91.38%?
    NetworkConnectionInfo.java?0.00%?
    NetworkConnectionInfoOrBuilder.java?0.00%?
    NetworkRequestMetric.java?49.16%?
    NetworkRequestMetricBuilder.java?95.97%?
    NetworkRequestMetricBuilderUtil.java?75.00%?
    NetworkRequestMetricOrBuilder.java?0.00%?
    Optional.java?86.67%?
    PendingPerfEvent.java?100.00%?
    PerfMetric.java?33.67%?
    PerfMetricOrBuilder.java?0.00%?
    PerfMetricValidator.java?93.55%?
    PerfSession.java?93.22%?
    PerfSessionOrBuilder.java?0.00%?
    PreDrawListener.java?94.12%?
    Rate.java?100.00%?
    RateLimiter.java?90.77%?
    RemoteConfigManager.java?91.43%?
    ResourceType.java?0.00%?
    ScreenTraceUtil.java?94.12%?
    SessionAwareObject.java?0.00%?
    SessionManager.java?100.00%?
    SessionVerbosity.java?68.42%?
    StorageUnit.java?57.89%?
    Timer.java?90.63%?
    Trace.java?95.83%?
    TraceMetric.java?43.14%?
    TraceMetricBuilder.java?100.00%?
    TraceMetricOrBuilder.java?0.00%?
    TransportInfo.java?0.00%?
    TransportInfoOrBuilder.java?0.00%?
    TransportManager.java?94.88%?
    URLAllowlist.java?94.44%?
    URLWrapper.java?0.00%?
    Utils.java?78.57%?

  • firebase-storage

    Overall coverage changed from 86.29% (fc5cde4) to 85.73% (015c8a5) by -0.56%.

    FilenameBase (fc5cde4)Merge (015c8a5)Diff
    NetworkRequest.java87.11%86.60%-0.52%
    StorageException.java69.09%65.45%-3.64%
    StorageTask.java84.59%83.38%-1.21%
    StreamDownloadTask.java88.89%88.41%-0.48%
    UploadTask.java83.17%81.52%-1.65%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dJ50778ilw.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,604 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hasL0Tmfiw/index.html

@rlazo rlazo merged commit b261373 into master Jul 26, 2023
163 checks passed
@rlazo rlazo deleted the rl.rel.generator.ignore branch July 26, 2023 20:02
emilypgoogle pushed a commit that referenced this pull request Jul 27, 2023
@rlazo @emilypgoogle
Add support to ignore specific commits from the release generator. (#…
903511c 
…5200)
@firebase firebase locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emilypgoogle emilypgoogle emilypgoogle approved these changes

@davidmotson davidmotson Awaiting requested review from davidmotson

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @emilypgoogle