Auto transform #5221
Auto transform #5221
Conversation
Release note changesNo release note changes were detected. If you made changes that should be |
|
The public api surface has changed for the subproject firebase-common: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
1 similar comment
|
The public api surface has changed for the subproject firebase-common: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Size Report 1Affected Products
Test Logs |
Coverage Report 1Affected ProductsNo changes between base commit (dff55b6) and merge commit (0868375).Test Logs |
|
The public api surface has changed for the subproject firebase-common: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
| @@ -0,0 +1,321 @@ | |||
| package com.google.firebase.gradle.plugins | |||
|
|
||
| fun getSymbol(line: String): String { | ||
| val parts = line.split(" ") | ||
| if (parts.get(0) == "val" || parts.get(0) == "class") { |
There was a problem hiding this comment.
You can use when to make it clearer
| var output: String = "" | ||
| var ignore = false | ||
| for (c in line) { | ||
| if (c == ':') { |
| } | ||
|
|
||
| fun copyDir(src: Path, dest: Path) { | ||
| Files.walk(src).forEach { |
There was a problem hiding this comment.
forEach is usually when you have an already existing chain of operations. Otherwise, an ol'good for loop is better.
| } | ||
|
|
||
| fun deprecateKTX(src: String, pkgName: String) { | ||
| File(src).walk().forEach { |
| output.add(lines[i]) | ||
| if (lines[i].contains("*/")) { | ||
| var symbol = "" | ||
| var ctr = i + 1 |
There was a problem hiding this comment.
it basically indicates the number of { - number of }.. This is basically to handle the exclude part in the dependencies
There was a problem hiding this comment.
probably we can come up with a better naming... not sure what though :-)
| } | ||
| } | ||
|
|
||
| fun readDependencies(path: String): List<String> { |
There was a problem hiding this comment.
you can read the whole file in a string, then find dependencies { and then start processing it.
There was a problem hiding this comment.
Feel free to ignore since it's not going to be merged to master.
| @@ -0,0 +1,29 @@ | |||
| // Copyright 2023 Google LLC | |||
|
Just to keep record: we still want to keep most of the tests in the KTX artifact to make sure usage of the api works for people not migrating. |
|
The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-common: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
This is WAI, please ignore. |
|
The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-common: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-common: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-common: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-common: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-common: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-common: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
|
The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-common: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
VinayGuthal
force-pushed
the
auto_transform
branch
from
ae586d6
to
af9ca1d
Compare
No description provided.