Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SafetyNet #5862

Merged
merged 18 commits into from
Apr 18, 2024
Merged

Remove SafetyNet #5862

merged 18 commits into from
Apr 18, 2024

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Apr 11, 2024

Per b/333906221,

This drops the SafetyNet sdk, and its related usage throughout app-check.

Although, some of the app-check removals may not be desired, so let me know if that's the case so I can revert or change them.

@daymxn daymxn requested review from rlazo and rosalyntan April 11, 2024 18:36
@daymxn daymxn self-assigned this Apr 11, 2024
Copy link
Contributor

github-actions bot commented Apr 11, 2024

Javadoc Changes:
--- /home/runner/diff/original/firebase-kotlindoc/android/client/firebase-appcheck-safetynet/_toc.yaml	2024-04-18 19:11:08.976556372 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/client/firebase-appcheck-safetynet/_toc.yaml	1970-01-01 00:00:00.000000000 +0000
@@ -1,12 +0,0 @@
-toc:
-- title: "com.google.firebase.appcheck.safetynet"
-  path: "/docs/reference/android/com/google/firebase/appcheck/safetynet/package-summary.html"
-
-  section:
-  - title: "Classes"
-
-    section:
-    - title: "SafetyNetAppCheckProviderFactory"
-      path: "/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html"
-
-
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html	2024-04-18 19:11:08.976556372 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html	1970-01-01 00:00:00.000000000 +0000
@@ -1,94 +0,0 @@
-<html devsite="true">
-  <head>
-    <title>SafetyNetAppCheckProviderFactory</title>
-{% setvar book_path %}/_book.yaml{% endsetvar %}
-{% include "docs/reference/android/_reference-head-tags.html" %}
-  </head>
-  <body>
-    <div id="metadata-info-block"></div>
-    <h1>SafetyNetAppCheckProviderFactory</h1>
-    <p>
-      <pre>public class <a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a> implements <a href="/docs/reference/android/com/google/firebase/appcheck/AppCheckProviderFactory.html">AppCheckProviderFactory</a></pre>
-    </p>
-    <hr>
-    <aside class="caution"><strong>This class is deprecated.</strong><br>
-      <p>Use <code>PlayIntegrityAppCheckProviderFactory</code> instead.</p>
-    </aside>
-    <p>Implementation of an <code><a href="/docs/reference/android/com/google/firebase/appcheck/AppCheckProviderFactory.html">AppCheckProviderFactory</a></code> that builds <code><a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/internal/SafetyNetAppCheckProvider.html">SafetyNetAppCheckProvider</a></code>s. This is the default implementation.</p>
-    <h2>Summary</h2>
-    <div class="devsite-table-wrapper">
-      <table class="responsive">
-        <colgroup>
-          <col width="40%">
-          <col>
-        </colgroup>
-        <thead>
-          <tr>
-            <th colspan="100%"><h3>Constants</h3></th>
-          </tr>
-        </thead>
-        <tbody class="list">
-          <tr>
-            <td><code>static&nbsp;final <a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a></code></td>
-            <td>
-              <div><code><a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#instance()">instance</a></code></div>
-            </td>
-          </tr>
-        </tbody>
-      </table>
-    </div>
-    <div class="devsite-table-wrapper">
-      <table class="responsive">
-        <colgroup>
-          <col width="40%">
-          <col>
-        </colgroup>
-        <thead>
-          <tr>
-            <th colspan="100%"><h3>Public methods</h3></th>
-          </tr>
-        </thead>
-        <tbody class="list">
-          <tr>
-            <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appcheck/AppCheckProvider.html">AppCheckProvider</a></code></td>
-            <td>
-              <div><code><a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#create(com.google.firebase.FirebaseApp)">create</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a>&nbsp;firebaseApp)</code></div>
-            </td>
-          </tr>
-          <tr>
-            <td><code>static @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a></code></td>
-            <td>
-              <div><code><span><del><a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#getInstance()">getInstance</a></del></span>()</code></div>
-              <p><strong>This method is deprecated.</strong>
-                <p>Use <code>PlayIntegrityAppCheckProviderFactory#getInstance</code> instead.</p>
-              </p>
-            </td>
-          </tr>
-        </tbody>
-      </table>
-    </div>
-    <div class="list">
-      <h2>Constants</h2>
-      <div class="api-item"><a name="getInstance()"></a><a name="setInstance()"></a><a name="getInstance--"></a><a name="setInstance--"></a>
-        <h3 class="api-name" id="instance()">instance</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;final&nbsp;<a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#instance()">instance</a></pre>
-      </div>
-    </div>
-    <div class="list">
-      <h2>Public methods</h2>
-      <div class="api-item"><a name="create-com.google.firebase.FirebaseApp-"></a><a name="create"></a>
-        <h3 class="api-name" id="create(com.google.firebase.FirebaseApp)">create</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appcheck/AppCheckProvider.html">AppCheckProvider</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#create(com.google.firebase.FirebaseApp)">create</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a>&nbsp;firebaseApp)</pre>
-      </div>
-      <div class="api-item"><a name="getInstance--"></a><a name="getinstance"></a>
-        <h3 class="api-name" id="getInstance()">getInstance</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a>&nbsp;<span><del><a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#getInstance()">getInstance</a></del></span>()</pre>
-        <aside class="caution"><strong>This method is deprecated.</strong><br>
-          <p>Use <code>PlayIntegrityAppCheckProviderFactory#getInstance</code> instead.</p>
-        </aside>
-        <p>Gets an instance of this class for installation into a <code><a href="/docs/reference/android/com/google/firebase/appcheck/FirebaseAppCheck.html">FirebaseAppCheck</a></code> instance.</p>
-      </div>
-    </div>
-  </body>
-</html>
-
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/appcheck/safetynet/package-summary.html	2024-04-18 19:11:08.976556372 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/appcheck/safetynet/package-summary.html	1970-01-01 00:00:00.000000000 +0000
@@ -1,30 +0,0 @@
-<html devsite="true">
-  <head>
-    <title>com.google.firebase.appcheck.safetynet</title>
-{% setvar book_path %}/_book.yaml{% endsetvar %}
-{% include "docs/reference/android/_reference-head-tags.html" %}
-  </head>
-  <body>
-    <h1>com.google.firebase.appcheck.safetynet</h1>
-    <h2>Classes</h2>
-    <div class="devsite-table-wrapper">
-      <table class="responsive">
-        <colgroup>
-          <col width="40%">
-          <col>
-        </colgroup>
-        <tbody class="list">
-          <tr>
-            <td><code><a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a></code></td>
-            <td>
-              <p><strong>This class is deprecated.</strong>
-                <p>Use <code>PlayIntegrityAppCheckProviderFactory</code> instead.</p>
-              </p>
-            </td>
-          </tr>
-        </tbody>
-      </table>
-    </div>
-  </body>
-</html>
-
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/client/firebase-appcheck-safetynet/_toc.yaml	2024-04-18 19:11:08.976556372 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/client/firebase-appcheck-safetynet/_toc.yaml	1970-01-01 00:00:00.000000000 +0000
@@ -1,12 +0,0 @@
-toc:
-- title: "com.google.firebase.appcheck.safetynet"
-  path: "/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/package-summary.html"
-
-  section:
-  - title: "Classes"
-
-    section:
-    - title: "SafetyNetAppCheckProviderFactory"
-      path: "/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html"
-
-
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html	2024-04-18 19:11:08.976556372 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html	1970-01-01 00:00:00.000000000 +0000
@@ -1,77 +0,0 @@
-<html devsite="true">
-  <head>
-    <title>SafetyNetAppCheckProviderFactory</title>
-{% setvar book_path %}/_book.yaml{% endsetvar %}
-{% include "docs/reference/kotlin/_reference-head-tags.html" %}
-  </head>
-  <body>
-    <div id="metadata-info-block"></div>
-    <h1>SafetyNetAppCheckProviderFactory</h1>
-    <p>
-      <pre>class <a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a> : <a href="/docs/reference/kotlin/com/google/firebase/appcheck/AppCheckProviderFactory.html">AppCheckProviderFactory</a></pre>
-    </p>
-    <hr>
-    <aside class="caution"><strong>This class is deprecated.</strong><br>
-      <p>Use <code>PlayIntegrityAppCheckProviderFactory</code> instead.</p>
-    </aside>
-    <p>Implementation of an <code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/AppCheckProviderFactory.html">AppCheckProviderFactory</a></code> that builds <code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/internal/SafetyNetAppCheckProvider.html">SafetyNetAppCheckProvider</a></code>s. This is the default implementation.</p>
-    <h2>Summary</h2>
-    <div class="devsite-table-wrapper">
-      <table class="responsive">
-        <colgroup>
-          <col width="40%">
-          <col>
-        </colgroup>
-        <thead>
-          <tr>
-            <th colspan="100%"><h3>Constants</h3></th>
-          </tr>
-        </thead>
-        <tbody class="list">
-          <tr>
-            <td><code>const <a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a>!</code></td>
-            <td>
-              <div><code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#instance()">instance</a></code></div>
-            </td>
-          </tr>
-        </tbody>
-      </table>
-    </div>
-    <div class="devsite-table-wrapper">
-      <table class="responsive">
-        <colgroup>
-          <col width="40%">
-          <col>
-        </colgroup>
-        <thead>
-          <tr>
-            <th colspan="100%"><h3>Public functions</h3></th>
-          </tr>
-        </thead>
-        <tbody class="list">
-          <tr>
-            <td><code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/AppCheckProvider.html">AppCheckProvider</a></code></td>
-            <td>
-              <div><code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#create(com.google.firebase.FirebaseApp)">create</a>(firebaseApp:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a>)</code></div>
-            </td>
-          </tr>
-        </tbody>
-      </table>
-    </div>
-    <div class="list">
-      <h2>Constants</h2>
-      <div class="api-item"><a name="getInstance()"></a><a name="setInstance()"></a><a name="getInstance--"></a><a name="setInstance--"></a>
-        <h3 class="api-name" id="instance()">instance</h3>
-        <pre class="api-signature no-pretty-print">const&nbsp;val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#instance()">instance</a>:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a>!</pre>
-      </div>
-    </div>
-    <div class="list">
-      <h2>Public functions</h2>
-      <div class="api-item"><a name="create-com.google.firebase.FirebaseApp-"></a><a name="create"></a>
-        <h3 class="api-name" id="create(com.google.firebase.FirebaseApp)">create</h3>
-        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#create(com.google.firebase.FirebaseApp)">create</a>(firebaseApp:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a>):&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/appcheck/AppCheckProvider.html">AppCheckProvider</a></pre>
-      </div>
-    </div>
-  </body>
-</html>
-
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/appcheck/safetynet/package-summary.html	2024-04-18 19:11:08.976556372 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/appcheck/safetynet/package-summary.html	1970-01-01 00:00:00.000000000 +0000
@@ -1,30 +0,0 @@
-<html devsite="true">
-  <head>
-    <title>com.google.firebase.appcheck.safetynet</title>
-{% setvar book_path %}/_book.yaml{% endsetvar %}
-{% include "docs/reference/kotlin/_reference-head-tags.html" %}
-  </head>
-  <body>
-    <h1>com.google.firebase.appcheck.safetynet</h1>
-    <h2>Classes</h2>
-    <div class="devsite-table-wrapper">
-      <table class="responsive">
-        <colgroup>
-          <col width="40%">
-          <col>
-        </colgroup>
-        <tbody class="list">
-          <tr>
-            <td><code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a></code></td>
-            <td>
-              <p><strong>This class is deprecated.</strong>
-                <p>Use <code>PlayIntegrityAppCheckProviderFactory</code> instead.</p>
-              </p>
-            </td>
-          </tr>
-        </tbody>
-      </table>
-    </div>
-  </body>
-</html>
-

Copy link
Contributor

github-actions bot commented Apr 11, 2024

buildSrc Test Results

37 tests   37 ✔️  1m 6s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit 1e7eb02.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Unit Test Results

     934 files  +   714       934 suites  +714   32m 14s ⏱️ + 28m 1s
  5 212 tests +3 911    5 191 ✔️ +3 906  21 💤 +  5  0 ±0 
10 485 runs  +7 867  10 443 ✔️ +7 857  42 💤 +10  0 ±0 

Results for commit 893e90d. ± Comparison against base commit 1d717ea.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 11, 2024

Size Report 1

Affected Products

  • firebase-appcheck

    TypeBase (ec9b699)Merge (5bb99db)Diff
    aar40.9 kB40.8 kB-72 B (-0.2%)
    apk (release)4.98 MB4.98 MB-192 B (-0.0%)
  • firebase-appcheck-debug

    TypeBase (ec9b699)Merge (5bb99db)Diff
    apk (release)4.99 MB4.99 MB-188 B (-0.0%)
  • firebase-appcheck-debug-testing

    TypeBase (ec9b699)Merge (5bb99db)Diff
    apk (release)5.17 MB5.17 MB-192 B (-0.0%)
  • firebase-appcheck-ktx

    TypeBase (ec9b699)Merge (5bb99db)Diff
    apk (release)4.99 MB4.99 MB-188 B (-0.0%)
  • firebase-appcheck-playintegrity

    TypeBase (ec9b699)Merge (5bb99db)Diff
    apk (release)5.04 MB5.04 MB-188 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/khYtvldXYa.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 11, 2024

Coverage Report 1

Affected Products

  • firebase-appcheck

    Overall coverage changed from 80.53% (ec9b699) to 80.50% (5bb99db) by -0.03%.

    FilenameBase (ec9b699)Merge (5bb99db)Diff
    NetworkClient.java78.31%78.05%-0.26%
  • firebase-database

    Overall coverage changed from 50.21% (ec9b699) to 50.19% (5bb99db) by -0.02%.

    FilenameBase (ec9b699)Merge (5bb99db)Diff
    DoubleNode.java100.00%88.24%-11.76%
  • firebase-inappmessaging

    Overall coverage changed from ? (ec9b699) to 39.24% (5bb99db) by ?.

    148 individual files with coverage change

    FilenameBase (ec9b699)Merge (5bb99db)Diff
    AbtIntegrationHelper.java?60.87%?
    AbtIntegrationHelper_Factory.java?0.00%?
    Action.java?76.47%?
    Analytics.java?0.00%?
    AnalyticsConstants.java?0.00%?
    AnalyticsEventsManager.java?85.19%?
    AnalyticsEventsModule.java?0.00%?
    AnalyticsEventsModule_ProvidesAnalyticsConnectorEventsFactory.java?0.00%?
    AnalyticsEventsModule_ProvidesAnalyticsEventsManagerFactory.java?0.00%?
    AnalyticsListener.java?0.00%?
    ApiClient.java?100.00%?
    ApiClientModule.java?0.00%?
    ApiClientModule_ProvidesApiClientFactory.java?0.00%?
    ApiClientModule_ProvidesDataCollectionHelperFactory.java?0.00%?
    ApiClientModule_ProvidesFirebaseAppFactory.java?0.00%?
    ApiClientModule_ProvidesFirebaseInstallationsFactory.java?0.00%?
    ApiClientModule_ProvidesSharedPreferencesUtilsFactory.java?0.00%?
    ApiClientModule_ProvidesTestDeviceHelperFactory.java?0.00%?
    AppComponent.java?0.00%?
    AppForeground.java?0.00%?
    ApplicationModule.java?0.00%?
    ApplicationModule_DeveloperListenerManagerFactory.java?0.00%?
    ApplicationModule_ProvidesApplicationFactory.java?0.00%?
    AppMeasurementModule.java?0.00%?
    AppMeasurementModule_ProvidesAnalyticsConnectorFactory.java?0.00%?
    AppMeasurementModule_ProvidesSubsriberFactory.java?0.00%?
    AutoValue_InstallationIdResult.java?33.33%?
    AutoValue_RateLimit.java?53.19%?
    BannerMessage.java?75.00%?
    Button.java?61.76%?
    CampaignAnalytics.java?33.22%?
    CampaignAnalyticsOrBuilder.java?0.00%?
    CampaignCache.java?0.00%?
    CampaignCacheClient.java?88.00%?
    CampaignCacheClient_Factory.java?0.00%?
    CampaignImpression.java?38.96%?
    CampaignImpressionList.java?39.25%?
    CampaignImpressionListOrBuilder.java?0.00%?
    CampaignImpressionOrBuilder.java?0.00%?
    CampaignMetadata.java?100.00%?
    CampaignProto.java?27.48%?
    CardMessage.java?78.48%?
    ClientAppInfo.java?35.79%?
    ClientAppInfoOrBuilder.java?0.00%?
    Clock.java?0.00%?
    CommonTypesProto.java?9.96%?
    DaggerAppComponent.java?0.00%?
    DaggerUniversalComponent.java?0.00%?
    DataCollectionHelper.java?87.50%?
    DataCollectionHelper_Factory.java?0.00%?
    DeveloperListenerManager.java?100.00%?
    DismissType.java?82.61%?
    DisplayCallbacksFactory.java?100.00%?
    DisplayCallbacksFactory_Factory.java?0.00%?
    DisplayCallbacksImpl.java?93.46%?
    EventType.java?76.19%?
    ExecutorsModule.java?0.00%?
    ExecutorsModule_ProvidesBackgroundExecutorFactory.java?0.00%?
    ExecutorsModule_ProvidesBlockingExecutorFactory.java?0.00%?
    ExecutorsModule_ProvidesLightWeightExecutorFactory.java?0.00%?
    ExperimentPayloadProto.java?6.05%?
    FetchEligibleCampaignsRequest.java?32.97%?
    FetchEligibleCampaignsRequestOrBuilder.java?0.00%?
    FetchEligibleCampaignsResponse.java?42.86%?
    FetchEligibleCampaignsResponseOrBuilder.java?0.00%?
    FetchErrorReason.java?52.17%?
    FiamAnalyticsConnectorListener.java?100.00%?
    FiamFetchService.java?0.00%?
    FirebaseAppScope.java?0.00%?
    FirebaseInAppMessaging.java?80.60%?
    FirebaseInAppMessagingCampaignAnalyticsProto.java?0.00%?
    FirebaseInAppMessagingClickListener.java?0.00%?
    FirebaseInAppMessagingContextualTrigger.java?0.00%?
    FirebaseInAppMessagingDismissListener.java?0.00%?
    FirebaseInAppMessagingDisplay.java?0.00%?
    FirebaseInAppMessagingDisplayCallbacks.java?100.00%?
    FirebaseInAppMessagingDisplayErrorListener.java?0.00%?
    FirebaseInAppMessagingImpressionListener.java?0.00%?
    FirebaseInAppMessagingRegistrar.java?0.00%?
    FirebaseInAppMessaging_Factory.java?0.00%?
    ForegroundFlowableModule.java?0.00%?
    ForegroundFlowableModule_ProvidesAppForegroundEventStreamFactory.java?0.00%?
    ForegroundNotifier.java?76.00%?
    GrpcChannelModule.java?0.00%?
    GrpcChannelModule_ProvidesGrpcChannelFactory.java?0.00%?
    GrpcChannelModule_ProvidesServiceHostFactory.java?0.00%?
    GrpcClient.java?100.00%?
    GrpcClientModule.java?0.00%?
    GrpcClientModule_ProvidesApiKeyHeadersFactory.java?0.00%?
    GrpcClientModule_ProvidesInAppMessagingSdkServingStubFactory.java?0.00%?
    GrpcClient_Factory.java?0.00%?
    ImageData.java?71.43%?
    ImageOnlyMessage.java?75.86%?
    ImpressionStorageClient.java?100.00%?
    ImpressionStorageClient_Factory.java?0.00%?
    ImpressionStore.java?0.00%?
    InAppMessage.java?24.24%?
    InAppMessageStreamManager.java?91.40%?
    InAppMessageStreamManager_Factory.java?0.00%?
    InAppMessaging.kt?0.00%?
    InAppMessagingSdkServingGrpc.java?45.95%?
    InstallationIdResult.java?100.00%?
    Logging.java?0.00%?
    MessagesProto.java?36.13%?
    MessageType.java?100.00%?
    MetricsLoggerClient.java?94.29%?
    ModalMessage.java?74.07%?
    ProgramaticContextualTriggers.java?0.00%?
    ProgrammaticContextualTriggerFlowableModule.java?0.00%?
    ProgrammaticContextualTriggerFlowableModule_ProvidesProgramaticContextualTriggersFactory.java?0.00%?
    ProgrammaticContextualTriggerFlowableModule_ProvidesProgramaticContextualTriggerStreamFactory.java?0.00%?
    ProgrammaticTrigger.java?0.00%?
    ProtoMarshallerClient.java?91.40%?
    ProtoMarshallerClient_Factory.java?0.00%?
    ProtoStorageClient.java?100.00%?
    ProtoStorageClientModule.java?0.00%?
    ProtoStorageClientModule_ProvidesProtoStorageClientForCampaignFactory.java?0.00%?
    ProtoStorageClientModule_ProvidesProtoStorageClientForImpressionStoreFactory.java?0.00%?
    ProtoStorageClientModule_ProvidesProtoStorageClientForLimiterStoreFactory.java?0.00%?
    ProviderInstaller.java?37.50%?
    ProviderInstaller_Factory.java?0.00%?
    ProxyAnalyticsConnector.java?67.95%?
    RateLimit.java?0.00%?
    RateLimiterClient.java?100.00%?
    RateLimiterClient_Factory.java?0.00%?
    RateLimitModule.java?0.00%?
    RateLimitModule_ProvidesAppForegroundRateLimitFactory.java?0.00%?
    RateLimitProto.java?52.69%?
    RenderErrorReason.java?82.61%?
    SchedulerModule.java?0.00%?
    SchedulerModule_ProvidesComputeSchedulerFactory.java?0.00%?
    SchedulerModule_ProvidesIOSchedulerFactory.java?0.00%?
    SchedulerModule_ProvidesMainThreadSchedulerFactory.java?0.00%?
    Schedulers.java?87.50%?
    Schedulers_Factory.java?0.00%?
    SharedPreferencesUtils.java?40.35%?
    SharedPreferencesUtils_Factory.java?0.00%?
    SystemClock.java?100.00%?
    SystemClockModule.java?0.00%?
    SystemClockModule_ProvidesSystemClockModuleFactory.java?0.00%?
    SystemClock_Factory.java?0.00%?
    TestDeviceHelper.java?100.00%?
    TestDeviceHelper_Factory.java?0.00%?
    Text.java?67.74%?
    TransportClientModule.java?0.00%?
    TransportClientModule_ProvidesMetricsLoggerClientFactory.java?0.00%?
    TriggeredInAppMessage.java?100.00%?
    UniversalComponent.java?0.00%?

  • firebase-messaging

    Overall coverage changed from 83.90% (ec9b699) to 83.97% (5bb99db) by +0.08%.

    FilenameBase (ec9b699)Merge (5bb99db)Diff
    RequestDeduplicator.java80.00%90.00%+10.00%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0TZ8pSYvuY.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 11, 2024

Startup Time Report 1

The report is too large (122,681 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5Sdjot62Cm/index.html

Copy link
Collaborator

@rlazo rlazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs work

@daymxn daymxn requested a review from rlazo April 11, 2024 20:38
@daymxn daymxn requested a review from rosalyntan April 16, 2024 20:55
@daymxn daymxn enabled auto-merge (squash) April 18, 2024 19:02
@daymxn daymxn merged commit 7040a87 into master Apr 18, 2024
164 of 168 checks passed
@daymxn daymxn deleted the daymon-remove-safetynet branch April 18, 2024 19:15
@firebase firebase locked and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants