-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SafetyNet #5862
Remove SafetyNet #5862
Conversation
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/client/firebase-appcheck-safetynet/_toc.yaml 2024-04-18 19:11:08.976556372 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/client/firebase-appcheck-safetynet/_toc.yaml 1970-01-01 00:00:00.000000000 +0000
@@ -1,12 +0,0 @@
-toc:
-- title: "com.google.firebase.appcheck.safetynet"
- path: "/docs/reference/android/com/google/firebase/appcheck/safetynet/package-summary.html"
-
- section:
- - title: "Classes"
-
- section:
- - title: "SafetyNetAppCheckProviderFactory"
- path: "/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html"
-
- --- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html 2024-04-18 19:11:08.976556372 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html 1970-01-01 00:00:00.000000000 +0000
@@ -1,94 +0,0 @@
-<html devsite="true">
- <head>
- <title>SafetyNetAppCheckProviderFactory</title>
-{% setvar book_path %}/_book.yaml{% endsetvar %}
-{% include "docs/reference/android/_reference-head-tags.html" %}
- </head>
- <body>
- <div id="metadata-info-block"></div>
- <h1>SafetyNetAppCheckProviderFactory</h1>
- <p>
- <pre>public class <a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a> implements <a href="/docs/reference/android/com/google/firebase/appcheck/AppCheckProviderFactory.html">AppCheckProviderFactory</a></pre>
- </p>
- <hr>
- <aside class="caution"><strong>This class is deprecated.</strong><br>
- <p>Use <code>PlayIntegrityAppCheckProviderFactory</code> instead.</p>
- </aside>
- <p>Implementation of an <code><a href="/docs/reference/android/com/google/firebase/appcheck/AppCheckProviderFactory.html">AppCheckProviderFactory</a></code> that builds <code><a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/internal/SafetyNetAppCheckProvider.html">SafetyNetAppCheckProvider</a></code>s. This is the default implementation.</p>
- <h2>Summary</h2>
- <div class="devsite-table-wrapper">
- <table class="responsive">
- <colgroup>
- <col width="40%">
- <col>
- </colgroup>
- <thead>
- <tr>
- <th colspan="100%"><h3>Constants</h3></th>
- </tr>
- </thead>
- <tbody class="list">
- <tr>
- <td><code>static final <a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a></code></td>
- <td>
- <div><code><a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#instance()">instance</a></code></div>
- </td>
- </tr>
- </tbody>
- </table>
- </div>
- <div class="devsite-table-wrapper">
- <table class="responsive">
- <colgroup>
- <col width="40%">
- <col>
- </colgroup>
- <thead>
- <tr>
- <th colspan="100%"><h3>Public methods</h3></th>
- </tr>
- </thead>
- <tbody class="list">
- <tr>
- <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appcheck/AppCheckProvider.html">AppCheckProvider</a></code></td>
- <td>
- <div><code><a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#create(com.google.firebase.FirebaseApp)">create</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a> firebaseApp)</code></div>
- </td>
- </tr>
- <tr>
- <td><code>static @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a></code></td>
- <td>
- <div><code><span><del><a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#getInstance()">getInstance</a></del></span>()</code></div>
- <p><strong>This method is deprecated.</strong>
- <p>Use <code>PlayIntegrityAppCheckProviderFactory#getInstance</code> instead.</p>
- </p>
- </td>
- </tr>
- </tbody>
- </table>
- </div>
- <div class="list">
- <h2>Constants</h2>
- <div class="api-item"><a name="getInstance()"></a><a name="setInstance()"></a><a name="getInstance--"></a><a name="setInstance--"></a>
- <h3 class="api-name" id="instance()">instance</h3>
- <pre class="api-signature no-pretty-print">public static final <a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a> <a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#instance()">instance</a></pre>
- </div>
- </div>
- <div class="list">
- <h2>Public methods</h2>
- <div class="api-item"><a name="create-com.google.firebase.FirebaseApp-"></a><a name="create"></a>
- <h3 class="api-name" id="create(com.google.firebase.FirebaseApp)">create</h3>
- <pre class="api-signature no-pretty-print">public @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appcheck/AppCheckProvider.html">AppCheckProvider</a> <a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#create(com.google.firebase.FirebaseApp)">create</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a> firebaseApp)</pre>
- </div>
- <div class="api-item"><a name="getInstance--"></a><a name="getinstance"></a>
- <h3 class="api-name" id="getInstance()">getInstance</h3>
- <pre class="api-signature no-pretty-print">public static @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a> <span><del><a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#getInstance()">getInstance</a></del></span>()</pre>
- <aside class="caution"><strong>This method is deprecated.</strong><br>
- <p>Use <code>PlayIntegrityAppCheckProviderFactory#getInstance</code> instead.</p>
- </aside>
- <p>Gets an instance of this class for installation into a <code><a href="/docs/reference/android/com/google/firebase/appcheck/FirebaseAppCheck.html">FirebaseAppCheck</a></code> instance.</p>
- </div>
- </div>
- </body>
-</html>
- --- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/appcheck/safetynet/package-summary.html 2024-04-18 19:11:08.976556372 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/appcheck/safetynet/package-summary.html 1970-01-01 00:00:00.000000000 +0000
@@ -1,30 +0,0 @@
-<html devsite="true">
- <head>
- <title>com.google.firebase.appcheck.safetynet</title>
-{% setvar book_path %}/_book.yaml{% endsetvar %}
-{% include "docs/reference/android/_reference-head-tags.html" %}
- </head>
- <body>
- <h1>com.google.firebase.appcheck.safetynet</h1>
- <h2>Classes</h2>
- <div class="devsite-table-wrapper">
- <table class="responsive">
- <colgroup>
- <col width="40%">
- <col>
- </colgroup>
- <tbody class="list">
- <tr>
- <td><code><a href="/docs/reference/android/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a></code></td>
- <td>
- <p><strong>This class is deprecated.</strong>
- <p>Use <code>PlayIntegrityAppCheckProviderFactory</code> instead.</p>
- </p>
- </td>
- </tr>
- </tbody>
- </table>
- </div>
- </body>
-</html>
- --- /home/runner/diff/original/firebase-kotlindoc/kotlin/client/firebase-appcheck-safetynet/_toc.yaml 2024-04-18 19:11:08.976556372 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/client/firebase-appcheck-safetynet/_toc.yaml 1970-01-01 00:00:00.000000000 +0000
@@ -1,12 +0,0 @@
-toc:
-- title: "com.google.firebase.appcheck.safetynet"
- path: "/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/package-summary.html"
-
- section:
- - title: "Classes"
-
- section:
- - title: "SafetyNetAppCheckProviderFactory"
- path: "/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html"
-
- --- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html 2024-04-18 19:11:08.976556372 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html 1970-01-01 00:00:00.000000000 +0000
@@ -1,77 +0,0 @@
-<html devsite="true">
- <head>
- <title>SafetyNetAppCheckProviderFactory</title>
-{% setvar book_path %}/_book.yaml{% endsetvar %}
-{% include "docs/reference/kotlin/_reference-head-tags.html" %}
- </head>
- <body>
- <div id="metadata-info-block"></div>
- <h1>SafetyNetAppCheckProviderFactory</h1>
- <p>
- <pre>class <a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a> : <a href="/docs/reference/kotlin/com/google/firebase/appcheck/AppCheckProviderFactory.html">AppCheckProviderFactory</a></pre>
- </p>
- <hr>
- <aside class="caution"><strong>This class is deprecated.</strong><br>
- <p>Use <code>PlayIntegrityAppCheckProviderFactory</code> instead.</p>
- </aside>
- <p>Implementation of an <code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/AppCheckProviderFactory.html">AppCheckProviderFactory</a></code> that builds <code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/internal/SafetyNetAppCheckProvider.html">SafetyNetAppCheckProvider</a></code>s. This is the default implementation.</p>
- <h2>Summary</h2>
- <div class="devsite-table-wrapper">
- <table class="responsive">
- <colgroup>
- <col width="40%">
- <col>
- </colgroup>
- <thead>
- <tr>
- <th colspan="100%"><h3>Constants</h3></th>
- </tr>
- </thead>
- <tbody class="list">
- <tr>
- <td><code>const <a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a>!</code></td>
- <td>
- <div><code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#instance()">instance</a></code></div>
- </td>
- </tr>
- </tbody>
- </table>
- </div>
- <div class="devsite-table-wrapper">
- <table class="responsive">
- <colgroup>
- <col width="40%">
- <col>
- </colgroup>
- <thead>
- <tr>
- <th colspan="100%"><h3>Public functions</h3></th>
- </tr>
- </thead>
- <tbody class="list">
- <tr>
- <td><code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/AppCheckProvider.html">AppCheckProvider</a></code></td>
- <td>
- <div><code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#create(com.google.firebase.FirebaseApp)">create</a>(firebaseApp: <a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a>)</code></div>
- </td>
- </tr>
- </tbody>
- </table>
- </div>
- <div class="list">
- <h2>Constants</h2>
- <div class="api-item"><a name="getInstance()"></a><a name="setInstance()"></a><a name="getInstance--"></a><a name="setInstance--"></a>
- <h3 class="api-name" id="instance()">instance</h3>
- <pre class="api-signature no-pretty-print">const val <a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#instance()">instance</a>: <a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a>!</pre>
- </div>
- </div>
- <div class="list">
- <h2>Public functions</h2>
- <div class="api-item"><a name="create-com.google.firebase.FirebaseApp-"></a><a name="create"></a>
- <h3 class="api-name" id="create(com.google.firebase.FirebaseApp)">create</h3>
- <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html#create(com.google.firebase.FirebaseApp)">create</a>(firebaseApp: <a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a>): <a href="/docs/reference/kotlin/com/google/firebase/appcheck/AppCheckProvider.html">AppCheckProvider</a></pre>
- </div>
- </div>
- </body>
-</html>
- --- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/appcheck/safetynet/package-summary.html 2024-04-18 19:11:08.976556372 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/appcheck/safetynet/package-summary.html 1970-01-01 00:00:00.000000000 +0000
@@ -1,30 +0,0 @@
-<html devsite="true">
- <head>
- <title>com.google.firebase.appcheck.safetynet</title>
-{% setvar book_path %}/_book.yaml{% endsetvar %}
-{% include "docs/reference/kotlin/_reference-head-tags.html" %}
- </head>
- <body>
- <h1>com.google.firebase.appcheck.safetynet</h1>
- <h2>Classes</h2>
- <div class="devsite-table-wrapper">
- <table class="responsive">
- <colgroup>
- <col width="40%">
- <col>
- </colgroup>
- <tbody class="list">
- <tr>
- <td><code><a href="/docs/reference/kotlin/com/google/firebase/appcheck/safetynet/SafetyNetAppCheckProviderFactory.html">SafetyNetAppCheckProviderFactory</a></code></td>
- <td>
- <p><strong>This class is deprecated.</strong>
- <p>Use <code>PlayIntegrityAppCheckProviderFactory</code> instead.</p>
- </p>
- </td>
- </tr>
- </tbody>
- </table>
- </div>
- </body>
-</html>
- |
Size Report 1Affected Products
Test Logs |
Coverage Report 1Affected Products
Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs work
Per b/333906221,
This drops the
SafetyNet
sdk, and its related usage throughout app-check.Although, some of the app-check removals may not be desired, so let me know if that's the case so I can revert or change them.