Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix copyRootGoogleServices task #5895

Merged
merged 14 commits into from
Apr 24, 2024
Merged

Fix copyRootGoogleServices task #5895

merged 14 commits into from
Apr 24, 2024

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Apr 23, 2024

Per b/322356188,

This fixes the issues with the copyRootGoogleServices task.

Namely, it seems there are various tasks in the pipeline that have implicit dependencies on source files- which gradle doesn't like. To fix this, we just ensure copyRootGoogleServices is set as a dependency of them all.

This PR also moves the copyRootGoogleServices task into our android library plugin- to keep everything together.

@daymxn daymxn self-assigned this Apr 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024 •
edited
Loading

buildSrc Test Results

37 tests   37 ✔️  1m 1s ⏱️
  8 suites    0 💤
  8 files      0 ❌

Results for commit 6694deb.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 23, 2024 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (5c3f7ef) and merge commit (1deab42).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7XHYGBZkX8.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024 •
edited
Loading

Unit Test Results

     916 files  ±0       916 suites  ±0   31m 50s ⏱️ -14s
  5 212 tests ±0    5 188 ✔️ ±0  22 💤 ±0  2 ❌ ±0 
10 385 runs  ±0  10 339 ✔️ ±0  44 💤 ±0  2 ❌ ±0 

For more details on these failures, see this check.

Results for commit 6694deb. ± Comparison against base commit 5c3f7ef.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 23, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.76% (5c3f7ef) to 44.77% (1deab42) by +0.02%.

    FilenameBase (5c3f7ef)Merge (1deab42)Diff
    DeleteMutation.java90.48%95.24%+4.76%
    LruGarbageCollector.java93.64%97.27%+3.64%

  • firebase-ml-modeldownloader

    Overall coverage changed from 83.32% (5c3f7ef) to 83.38% (1deab42) by +0.06%.

    FilenameBase (5c3f7ef)Merge (1deab42)Diff
    FirebaseModelDownloader.java84.05%84.66%+0.61%

  • firebase-storage

    Overall coverage changed from ? (5c3f7ef) to 84.04% (1deab42) by ?.

    48 individual files with coverage change

    FilenameBase (5c3f7ef)Merge (1deab42)Diff
    ActivityLifecycleListener.java?74.14%?
    AdaptiveStreamBuffer.java?84.62%?
    CancelException.java?100.00%?
    CancellableTask.java?100.00%?
    ControllableTask.java?100.00%?
    DeleteNetworkRequest.java?100.00%?
    DeleteStorageTask.java?100.00%?
    ExponentialBackoffSender.java?86.00%?
    FileDownloadTask.java?80.00%?
    FirebaseStorage.java?83.67%?
    FirebaseStorageComponent.java?100.00%?
    GetDownloadUrlTask.java?96.77%?
    GetMetadataNetworkRequest.java?100.00%?
    GetMetadataTask.java?85.19%?
    GetNetworkRequest.java?100.00%?
    HttpURLConnectionFactory.java?0.00%?
    HttpURLConnectionFactoryImpl.java?50.00%?
    ListNetworkRequest.java?100.00%?
    ListResult.java?100.00%?
    ListTask.java?85.71%?
    NetworkRequest.java?87.29%?
    OnPausedListener.java?0.00%?
    OnProgressListener.java?0.00%?
    ResumableNetworkRequest.java?100.00%?
    ResumableUploadByteRequest.java?90.91%?
    ResumableUploadCancelRequest.java?100.00%?
    ResumableUploadQueryRequest.java?100.00%?
    ResumableUploadStartRequest.java?95.24%?
    Slashes.java?88.24%?
    Sleeper.java?0.00%?
    SleeperImpl.java?100.00%?
    SmartHandler.java?92.31%?
    Storage.kt?39.58%?
    StorageException.java?69.09%?
    StorageMetadata.java?86.34%?
    StorageReference.java?89.94%?
    StorageReferenceUri.java?100.00%?
    StorageRegistrar.java?100.00%?
    StorageTask.java?83.69%?
    StorageTaskManager.java?100.00%?
    StorageTaskScheduler.java?95.45%?
    StreamDownloadTask.java?88.41%?
    TaskListenerImpl.java?100.00%?
    TaskState.kt?0.00%?
    UpdateMetadataNetworkRequest.java?100.00%?
    UpdateMetadataTask.java?82.14%?
    UploadTask.java?81.52%?
    Util.java?73.24%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XD6QYaVaaa.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,667 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BozzvEdEb4/index.html

@rlazo rlazo merged commit 4583328 into master Apr 24, 2024
144 of 159 checks passed
@rlazo rlazo deleted the daymon-fix-googleservices branch April 24, 2024 01:29
@rlazo rlazo mentioned this pull request Apr 24, 2024
Closed
@firebase firebase locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees

@daymxn daymxn

Labels
no-changelog size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daymxn @google-oss-bot @rlazo