Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gMaven check to prevent an artifact from unintentionally exiting … #5933

Merged
merged 11 commits into from
May 13, 2024

Conversation

davidmotson
Copy link
Collaborator

@davidmotson davidmotson commented May 6, 2024

…beta

NO_RELEASE_CHANGE

Copy link
Contributor

github-actions bot commented May 6, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

github-actions bot commented May 6, 2024

buildSrc Test Results

37 tests   37 ✔️  1m 6s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit d277d6b.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 6, 2024

Copy link
Contributor

github-actions bot commented May 6, 2024

Unit Test Results

     950 files  +  18       950 suites  +18   35m 11s ⏱️ + 2m 31s
  5 215 tests ±    0    5 193 ✔️ +    1  22 💤 ±0  0  - 1 
10 515 runs  +132  10 471 ✔️ +133  44 💤 ±0  0  - 1 

Results for commit d277d6b. ± Comparison against base commit 4d2fbfd.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 6, 2024

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.76% (4d2fbfd) to 44.77% (65e7839) by +0.02%.

    FilenameBase (4d2fbfd)Merge (65e7839)Diff
    LruGarbageCollector.java93.64%97.27%+3.64%
  • firebase-installations

    Overall coverage changed from ? (4d2fbfd) to 58.68% (65e7839) by ?.

    23 individual files with coverage change

    FilenameBase (4d2fbfd)Merge (65e7839)Diff
    AutoValue_InstallationResponse.java?58.93%?
    AutoValue_PersistedInstallationEntry.java?61.18%?
    AutoValue_TokenResult.java?45.65%?
    AwaitListener.java?0.00%?
    Clock.java?0.00%?
    CrossProcessLock.java?51.85%?
    FirebaseInstallations.java?96.62%?
    FirebaseInstallationServiceClient.java?4.80%?
    FirebaseInstallationsException.java?78.57%?
    FirebaseInstallationsRegistrar.java?100.00%?
    GetAuthTokenListener.java?100.00%?
    GetIdListener.java?70.00%?
    IidStore.java?22.39%?
    InstallationResponse.java?100.00%?
    Installations.kt?40.00%?
    PersistedInstallation.java?97.01%?
    PersistedInstallationEntry.java?100.00%?
    RandomFidGenerator.java?20.00%?
    RequestLimiter.java?100.00%?
    StateListener.java?0.00%?
    SystemClock.java?100.00%?
    TokenResult.java?100.00%?
    Utils.java?95.00%?

  • firebase-messaging

    Overall coverage changed from 84.14% (4d2fbfd) to 84.22% (65e7839) by +0.07%.

    FilenameBase (4d2fbfd)Merge (65e7839)Diff
    FirebaseMessaging.java76.40%76.00%-0.40%
    Metadata.java36.51%41.27%+4.76%
  • firebase-storage

    FilenameBase (4d2fbfd)Merge (65e7839)Diff
    NetworkRequest.java87.85%87.29%-0.55%
    StreamDownloadTask.java88.41%88.89%+0.48%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QrtPPmGG5p.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 6, 2024

Startup Time Report 1

The report is too large (122,603 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YFeeEqfGAT/index.html

@davidmotson davidmotson requested a review from rlazo May 7, 2024 19:53
@rlazo
Copy link
Collaborator

rlazo commented May 7, 2024

Could you move this check from github actions to maven? That way the failure will be impossible to be ignored, since it won't let the artifacts be build. You can modify the PublishingPlugin::apply method with something similar to (not full implementation)

        for (releasingLibrary in releasingLibraries) {
          if (releasingLibrary.isBeta && !releasingLibrary.version.contains("beta"))
            throw GradleException("You are releasing a beta SDK as non beta!")
        }

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@davidmotson davidmotson merged commit 091e1e1 into master May 13, 2024
171 of 175 checks passed
@davidmotson davidmotson deleted the davidmotson.add_beta_exit_check branch May 13, 2024 23:33
@firebase firebase locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants