Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment the equals() and hashCode() methods in GeneratedConnector and GeneratedConnector #5970

Merged
merged 1 commit into from
May 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,20 @@ public interface GeneratedConnector {
* @param other The object to compare to this for equality.
* @return `other === this`
*/
override fun equals(other: Any?): Boolean
// TODO: Uncomment equals() once the codegen changes in cl/634029357 are released in the latest
// firestore-tools for a month or so, as adding this method is a breaking change as it forces the
// generated classes to explicitly override this method.
// override fun equals(other: Any?): Boolean

/**
* Calculates and returns the hash code for this object.
*
* @return the hash code for this object.
*/
override fun hashCode(): Int
// TODO: Uncomment hashCode() once the codegen changes in cl/634029357 are released in the latest
// firestore-tools for a month or so, as adding this method is a breaking change as it forces the
// generated classes to explicitly override this method.
// override fun hashCode(): Int

/**
* Returns a string representation of this object, useful for debugging.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,20 @@ public interface GeneratedOperation<Connector : GeneratedConnector, Data, Variab
* @param other The object to compare to this for equality.
* @return `other === this`
*/
override fun equals(other: Any?): Boolean
// TODO: Uncomment equals() once the codegen changes in cl/634029357 are released in the latest
// firestore-tools for a month or so, as adding this method is a breaking change as it forces the
// generated classes to explicitly override this method.
// override fun equals(other: Any?): Boolean

/**
* Calculates and returns the hash code for this object.
*
* @return the hash code for this object.
*/
override fun hashCode(): Int
// TODO: Uncomment hashCode() once the codegen changes in cl/634029357 are released in the latest
// firestore-tools for a month or so, as adding this method is a breaking change as it forces the
// generated classes to explicitly override this method.
// override fun hashCode(): Int

/**
* Returns a string representation of this object, useful for debugging.
Expand Down
Loading