Implement Spotless formatting #6100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note changesNo release note changes were detected. If you made changes that should be |
Generated by 🚫 Danger |
Unit Test Results 954 files ±0 954 suites ±0 34m 44s ⏱️ -12s For more details on these failures, see this check. Results for commit 10e880d. ± Comparison against base commit 4db5dc8. ♻️ This comment has been updated with latest results. |
Size Report 1Affected Products
Test Logs |
Coverage Report 1Affected Products
Test Logs |
rlazo
approved these changes
Jul 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO_RELEASE_CHANGELOG
This may require a lot of PRs to rebase/merge. As a resolution, outstanding PRs could add Spotless themselves like done in the first commit and run
spotlessApplybefore the merge. Perhaps adding Spotless should be its own commit to main so outstanding branches can just pull main and cherry pick in?Updated root documentation, sessions and vertex both still link to ktfmt for their formatting, how do we want to update that?
Google Java Format was updated to latest.
ktfmtwas not. We are currently using a version from 2022,0.41. Latest is0.51, however, upgrading will require a reformat. Do we want to pre-emptively upgrade now and format with the rest of these formatting changes? Current latest release of Spotless does not have configuration for ktfmt trailing comma formatting, which was added recently. It's committed to the repo 3 weeks ago but they haven't had a release.