Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete code generated by the data connect cli #6163

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Aug 7, 2024

Delete all of the code generated by the Data Connect CLI. For now, it needs to be manually generated and copy/pasted. A follow-up PR will integrate the gradle plugin added in #6162 to run code generation on demand.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 7, 2024

Coverage Report 1

Affected Products

No changes between base commit (a8f1ca2) and merge commit (5102bb7).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QVB9DAeTRG.html

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Unit Test Results

0 files   -   34  0 suites   - 34   0s ⏱️ -46s
0 tests  - 311  0 ✔️  - 311  0 💤 ±0  0 ±0 
0 runs   - 622  0 ✔️  - 622  0 💤 ±0  0 ±0 

Results for commit 99da135. ± Comparison against base commit d1441e4.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 7, 2024

Size Report 1

Affected Products

  • base

    TypeBase (a8f1ca2)Merge (5102bb7)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)
  • firebase-dataconnect

    TypeBase (a8f1ca2)Merge (5102bb7)Diff
    aar?698 kB? (?)
    apk (aggressive)?279 kB? (?)
    apk (release)?10.6 MB? (?)
  • protolite-well-known-types

    TypeBase (a8f1ca2)Merge (5102bb7)Diff
    aar?1.01 MB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?1.68 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hMaXnBTMmj.html

Base automatically changed from dconeybe/GradlePluginProper to dataconnect August 8, 2024 23:04
@dconeybe dconeybe marked this pull request as ready for review August 9, 2024 03:17
@dconeybe dconeybe merged commit 31c440a into dataconnect Aug 9, 2024
13 checks passed
@dconeybe dconeybe deleted the dconeybe/DeletedGeneratedCode branch August 9, 2024 03:18
@firebase firebase locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants