Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnyScalarIntegrationTest.kt added #6213

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

dconeybe
Copy link
Contributor

This is the first part of adding Any scalar support to Data Connect (Googlers see b/361367932). This PR merely ensures that the wire protocol handles Any types as expected. Follow-up PR(s) will actually implement the functionality for the generated SDK.

@dconeybe dconeybe self-assigned this Aug 23, 2024
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-dataconnect

    Overall coverage changed from ? (b49310f) to 9.78% (4e43240) by ?.

    57 individual files with coverage change

    FilenameBase (b49310f)Merge (4e43240)Diff
    ActiveQueries.kt?0.00%?
    ActiveQuery.kt?0.00%?
    ActiveQueryKey.kt?0.00%?
    ActiveQueryResult.kt?0.00%?
    Comparisons.kt?0.00%?
    ConnectorConfig.kt?33.33%?
    CoroutineExceptionHandler.kt?50.00%?
    DataConnectAppCheck.kt?0.00%?
    DataConnectAuth.kt?0.00%?
    DataConnectCredentialsTokenManager.kt?0.00%?
    DataConnectError.kt?0.00%?
    DataConnectException.kt?0.00%?
    DataConnectGrpcClient.kt?0.00%?
    DataConnectGrpcMetadata.kt?65.82%?
    DataConnectGrpcRPCs.kt?0.00%?
    DataConnectSettings.kt?33.33%?
    DataConnectUntypedData.kt?0.00%?
    DataConnectUntypedVariables.kt?0.00%?
    DateSerializer.kt?0.00%?
    Emitters.kt?0.00%?
    FirebaseDataConnect.kt?21.43%?
    FirebaseDataConnectFactory.kt?29.17%?
    FirebaseDataConnectImpl.kt?34.12%?
    FirebaseDataConnectRegistrar.kt?100.00%?
    GeneratedConnector.kt?0.00%?
    GeneratedMutation.kt?0.00%?
    GeneratedOperation.kt?0.00%?
    GeneratedQuery.kt?0.00%?
    LiveQueries.kt?0.00%?
    LiveQuery.kt?0.00%?
    Logger.kt?52.17%?
    LogLevel.kt?100.00%?
    MutationRef.kt?0.00%?
    MutationRefImpl.kt?21.95%?
    OldQueryManager.kt?0.00%?
    OperationRef.kt?0.00%?
    OperationRefImpl.kt?24.00%?
    OptionalVariable.kt?0.00%?
    ProtoStructDecoder.kt?0.00%?
    ProtoStructEncoder.kt?0.00%?
    ProtoUtil.kt?0.00%?
    QueryExecutor.kt?0.00%?
    QueryExecutorResult.kt?0.00%?
    QueryManager.kt?0.00%?
    QueryRef.kt?0.00%?
    QueryRefImpl.kt?23.53%?
    QuerySubscription.kt?0.00%?
    QuerySubscriptionImpl.kt?0.00%?
    QuerySubscriptionInternal.kt?0.00%?
    RegisteredDataDeserialzer.kt?0.00%?
    SafeCollector.common.kt?0.00%?
    TimestampSerializer.kt?0.00%?
    TypedActiveQueries.kt?0.00%?
    TypedActiveQuery.kt?0.00%?
    TypedActiveQueryKey.kt?0.00%?
    Util.kt?6.96%?
    UUIDSerializer.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kxkSft2BGC.html

Copy link
Contributor

Unit Test Results

  36 files    36 suites   1m 13s ⏱️
328 tests 328 ✔️ 0 💤 0
656 runs  656 ✔️ 0 💤 0

Results for commit e53c218.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (b49310f)Merge (4e43240)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)
  • firebase-dataconnect

    TypeBase (b49310f)Merge (4e43240)Diff
    aar?719 kB? (?)
    apk (aggressive)?520 kB? (?)
    apk (release)?11.0 MB? (?)
  • protolite-well-known-types

    TypeBase (b49310f)Merge (4e43240)Diff
    aar?1.01 MB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?1.68 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jXNLK1eVqx.html

@dconeybe
Copy link
Contributor Author

 Smoke Tests are flaky and the test failures seem completely unrelated to this PR. I'm going to ignore the failure.

@dconeybe dconeybe merged commit dcccf16 into dataconnect Aug 23, 2024
33 of 34 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/AnyScalar branch August 23, 2024 19:38
@firebase firebase locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants