Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in class made final check in semver #6246

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Fix typo in class made final check in semver #6246

merged 2 commits into from
Sep 11, 2024

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Sep 10, 2024

The error message for classes made final has "abstract" instead of "final" on them.

@rlazo
Fix typo in class made final check in semver
e6b5ba7 
The error message for classes made final has "abstract" instead of
"final" on them.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 10, 2024 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@rlazo rlazo enabled auto-merge (squash) September 10, 2024 16:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 10, 2024 •
edited
Loading

buildSrc Test Results

37 tests   37 ✔️  1m 11s ⏱️
  8 suites    0 💤
  8 files      0 ❌

Results for commit a92962f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 10, 2024 •
edited
Loading

Unit Test Results

     968 files  +     954       968 suites  +954   35m 26s ⏱️ + 35m 11s
  5 323 tests +  5 219    5 302 ✔️ +  5 198  21 💤 +21  0 ❌ ±0 
10 731 runs  +10 523  10 689 ✔️ +10 481  42 💤 +42  0 ❌ ±0 

Results for commit a92962f. ± Comparison against base commit 994542e.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 10, 2024 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (994542e) and merge commit (40aa83f).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/x7wYkb4trh.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 10, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 46.04% (994542e) to 46.06% (40aa83f) by +0.02%.

    FilenameBase (994542e)Merge (40aa83f)Diff
    LruGarbageCollector.java93.64%97.27%+3.64%
    SetMutation.java94.44%97.22%+2.78%

  • firebase-ml-modeldownloader

    Overall coverage changed from 83.32% (994542e) to 83.38% (40aa83f) by +0.06%.

    FilenameBase (994542e)Merge (40aa83f)Diff
    FirebaseModelDownloader.java84.05%84.66%+0.61%

  • firebase-storage

    Overall coverage changed from ? (994542e) to 84.08% (40aa83f) by ?.

    48 individual files with coverage change

    FilenameBase (994542e)Merge (40aa83f)Diff
    ActivityLifecycleListener.java?74.14%?
    AdaptiveStreamBuffer.java?84.62%?
    CancelException.java?100.00%?
    CancellableTask.java?100.00%?
    ControllableTask.java?100.00%?
    DeleteNetworkRequest.java?100.00%?
    DeleteStorageTask.java?100.00%?
    ExponentialBackoffSender.java?86.00%?
    FileDownloadTask.java?80.00%?
    FirebaseStorage.java?83.67%?
    FirebaseStorageComponent.java?100.00%?
    GetDownloadUrlTask.java?96.77%?
    GetMetadataNetworkRequest.java?100.00%?
    GetMetadataTask.java?85.19%?
    GetNetworkRequest.java?100.00%?
    HttpURLConnectionFactory.java?0.00%?
    HttpURLConnectionFactoryImpl.java?50.00%?
    ListNetworkRequest.java?100.00%?
    ListResult.java?100.00%?
    ListTask.java?85.71%?
    NetworkRequest.java?87.29%?
    OnPausedListener.java?0.00%?
    OnProgressListener.java?0.00%?
    ResumableNetworkRequest.java?100.00%?
    ResumableUploadByteRequest.java?90.91%?
    ResumableUploadCancelRequest.java?100.00%?
    ResumableUploadQueryRequest.java?100.00%?
    ResumableUploadStartRequest.java?95.24%?
    Slashes.java?88.24%?
    Sleeper.java?0.00%?
    SleeperImpl.java?100.00%?
    SmartHandler.java?92.31%?
    Storage.kt?39.58%?
    StorageException.java?69.09%?
    StorageMetadata.java?86.34%?
    StorageReference.java?89.94%?
    StorageReferenceUri.java?100.00%?
    StorageRegistrar.java?100.00%?
    StorageTask.java?83.69%?
    StorageTaskManager.java?100.00%?
    StorageTaskScheduler.java?95.45%?
    StreamDownloadTask.java?88.89%?
    TaskListenerImpl.java?100.00%?
    TaskState.kt?0.00%?
    UpdateMetadataNetworkRequest.java?100.00%?
    UpdateMetadataTask.java?82.14%?
    UploadTask.java?81.52%?
    Util.java?73.24%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EweERIpEBf.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 10, 2024 •
edited
Loading

Startup Time Report 1

The report is too large (122,609 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tXsUboYnWC/index.html

@rlazo
Copy link
Collaborator Author

rlazo commented Sep 11, 2024

friendly ping

@rlazo rlazo merged commit 10fa49c into main Sep 11, 2024
248 of 253 checks passed
@rlazo rlazo deleted the rl.semver.abstract.final branch September 11, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinayGuthal VinayGuthal VinayGuthal approved these changes

@emilypgoogle emilypgoogle Awaiting requested review from emilypgoogle

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @VinayGuthal