Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new line at the end of release note files #6257

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Sep 13, 2024

Also, remove the unused make_release_notes.py file

Copy link
Contributor

github-actions bot commented Sep 13, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@rlazo rlazo enabled auto-merge (squash) September 13, 2024 21:19
Copy link
Contributor

github-actions bot commented Sep 13, 2024

Unit Test Results

     968 files  +     960       968 suites  +960   35m 21s ⏱️ + 34m 54s
  5 323 tests +  5 301    5 301 ✔️ +  5 279  21 💤 +21  1 +1 
10 731 runs  +10 687  10 688 ✔️ +10 644  42 💤 +42  1 +1 

For more details on these failures, see this check.

Results for commit 98bd6e8. ± Comparison against base commit 48d460c.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 13, 2024

Copy link
Contributor

github-actions bot commented Sep 13, 2024

buildSrc Test Results

37 tests   37 ✔️  1m 5s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit 64986d9.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 13, 2024

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.21% (d153670) to 50.16% (8f2a68c) by -0.04%.

    FilenameBase (d153670)Merge (8f2a68c)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
  • firebase-firestore

    Overall coverage changed from 46.05% (d153670) to 46.06% (8f2a68c) by +0.02%.

    FilenameBase (d153670)Merge (8f2a68c)Diff
    LruGarbageCollector.java93.64%97.27%+3.64%
  • firebase-installations

    Overall coverage changed from ? (d153670) to 58.68% (8f2a68c) by ?.

    23 individual files with coverage change

    FilenameBase (d153670)Merge (8f2a68c)Diff
    AutoValue_InstallationResponse.java?58.93%?
    AutoValue_PersistedInstallationEntry.java?61.18%?
    AutoValue_TokenResult.java?45.65%?
    AwaitListener.java?0.00%?
    Clock.java?0.00%?
    CrossProcessLock.java?51.85%?
    FirebaseInstallations.java?96.62%?
    FirebaseInstallationServiceClient.java?4.80%?
    FirebaseInstallationsException.java?78.57%?
    FirebaseInstallationsRegistrar.java?100.00%?
    GetAuthTokenListener.java?100.00%?
    GetIdListener.java?70.00%?
    IidStore.java?22.39%?
    InstallationResponse.java?100.00%?
    Installations.kt?40.00%?
    PersistedInstallation.java?97.01%?
    PersistedInstallationEntry.java?100.00%?
    RandomFidGenerator.java?20.00%?
    RequestLimiter.java?100.00%?
    StateListener.java?0.00%?
    SystemClock.java?100.00%?
    TokenResult.java?100.00%?
    Utils.java?95.00%?

  • firebase-messaging

    Overall coverage changed from 84.13% (d153670) to 84.28% (8f2a68c) by +0.15%.

    FilenameBase (d153670)Merge (8f2a68c)Diff
    FirebaseMessaging.java76.40%76.00%-0.40%
    Metadata.java36.51%41.27%+4.76%
    RequestDeduplicator.java80.00%90.00%+10.00%
  • firebase-ml-modeldownloader

    Overall coverage changed from 83.38% (d153670) to 83.32% (8f2a68c) by -0.06%.

    FilenameBase (d153670)Merge (8f2a68c)Diff
    FirebaseModelDownloader.java84.66%84.05%-0.61%
  • firebase-storage

    Overall coverage changed from 84.08% (d153670) to 83.96% (8f2a68c) by -0.12%.

    FilenameBase (d153670)Merge (8f2a68c)Diff
    StorageException.java69.09%65.45%-3.64%
    StorageTask.java83.69%83.38%-0.30%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Y3xvNoyBvX.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 13, 2024

Startup Time Report 1

The report is too large (120,923 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/V0ABar7JnL/index.html

@rlazo
Copy link
Collaborator Author

rlazo commented Sep 17, 2024

friendly ping

1 similar comment
@rlazo
Copy link
Collaborator Author

rlazo commented Sep 17, 2024

friendly ping

@rlazo rlazo merged commit c56bc5d into main Sep 18, 2024
248 of 252 checks passed
@rlazo rlazo deleted the rl.release.notes.newline branch September 18, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants