Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant null declaration #6281

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Remove redundant null declaration #6281

merged 1 commit into from
Sep 19, 2024

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Sep 19, 2024

Since the constructor is private, and the builder sets it to null if missing, this declaration is actually redundant.

b/368368914

Since the constructor is private, and the builder sets it to null if
missing, this declaration is actually redundant.

b/368368914
Copy link
Contributor

github-actions bot commented Sep 19, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (3c842c7) and merge commit (c94232c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mkjA5mZJxO.html

@rlazo rlazo enabled auto-merge (squash) September 19, 2024 19:22
Copy link
Contributor

Unit Test Results

  16 files  ±0    16 suites  ±0   15s ⏱️ ±0s
108 tests ±0  108 ✔️ ±0  0 💤 ±0  0 ±0 
216 runs  ±0  216 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 867e517. ± Comparison against base commit 3c842c7.

@google-oss-bot
Copy link
Contributor

@rlazo rlazo merged commit 2365b9b into main Sep 19, 2024
31 of 32 checks passed
@rlazo rlazo deleted the rl.schema.remove.null branch September 19, 2024 19:46
@rlazo rlazo added this to the vertexai-ga milestone Sep 21, 2024
@firebase firebase locked and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants