Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul AnyScalarIntegrationTest.kt #6283

Merged

Conversation

dconeybe
Copy link
Contributor

This prepares the tests for the upcoming tests that include codegen.

Googlers see b/361367932 for full details.

@dconeybe dconeybe self-assigned this Sep 19, 2024
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

Unit Test Results

   919 files     919 suites   33m 22s ⏱️
5 024 tests 5 002 ✔️ 21 💤 1
9 968 runs  9 925 ✔️ 42 💤 1

For more details on these failures, see this check.

Results for commit 46fd9d8.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)
  • firebase-abt

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?12.4 kB? (?)
    apk (aggressive)?141 kB? (?)
    apk (release)?4.41 MB? (?)
  • firebase-annotations

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?12.0 kB? (?)
  • firebase-appcheck

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?39.2 kB? (?)
    apk (aggressive)?390 kB? (?)
    apk (release)?4.88 MB? (?)
  • firebase-appcheck-debug

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?9.34 kB? (?)
    apk (aggressive)?396 kB? (?)
    apk (release)?4.89 MB? (?)
  • firebase-appcheck-debug-testing

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?5.39 kB? (?)
    apk (aggressive)?421 kB? (?)
    apk (release)?5.05 MB? (?)
  • firebase-appcheck-interop

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.13 kB? (?)
    apk (aggressive)?316 kB? (?)
    apk (release)?1.84 MB? (?)
  • firebase-appcheck-ktx

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.52 kB? (?)
    apk (aggressive)?390 kB? (?)
    apk (release)?4.88 MB? (?)
  • firebase-appcheck-playintegrity

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?9.12 kB? (?)
    apk (aggressive)?405 kB? (?)
    apk (release)?4.93 MB? (?)
  • firebase-appdistribution

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?230 kB? (?)
    apk (aggressive)?1.08 MB? (?)
    apk (release)?7.01 MB? (?)
  • firebase-appdistribution-api

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?18.9 kB? (?)
    apk (aggressive)?145 kB? (?)
    apk (release)?4.42 MB? (?)
  • firebase-appdistribution-api-ktx

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.58 kB? (?)
    apk (aggressive)?145 kB? (?)
    apk (release)?4.42 MB? (?)
  • firebase-common

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?116 kB? (?)
    apk (aggressive)?140 kB? (?)
    apk (release)?4.45 MB? (?)
  • firebase-common-ktx

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.18 kB? (?)
    apk (aggressive)?141 kB? (?)
    apk (release)?4.45 MB? (?)
  • firebase-components

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?45.7 kB? (?)
    apk (aggressive)?20.8 kB? (?)
    apk (release)?2.06 MB? (?)
  • firebase-config

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?108 kB? (?)
    apk (aggressive)?211 kB? (?)
    apk (release)?4.58 MB? (?)
  • firebase-config-interop

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?10.5 kB? (?)
    apk (aggressive)?20.8 kB? (?)
    apk (release)?2.02 MB? (?)
  • firebase-config-ktx

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.26 kB? (?)
    apk (aggressive)?211 kB? (?)
    apk (release)?4.58 MB? (?)
  • firebase-crashlytics

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?410 kB? (?)
    apk (aggressive)?698 kB? (?)
    apk (release)?5.85 MB? (?)
  • firebase-crashlytics-ktx

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.54 kB? (?)
    apk (aggressive)?698 kB? (?)
    apk (release)?5.85 MB? (?)
  • firebase-crashlytics-ndk

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?1.65 MB? (?)
    apk (aggressive / arm64-v8a)?1.87 MB? (?)
    apk (aggressive / armeabi-v7a)?1.34 MB? (?)
    apk (aggressive / x86)?1.85 MB? (?)
    apk (aggressive / x86_64)?1.91 MB? (?)
    apk (release / arm64-v8a)?7.01 MB? (?)
    apk (release / armeabi-v7a)?6.49 MB? (?)
    apk (release / x86)?6.99 MB? (?)
    apk (release / x86_64)?7.06 MB? (?)
  • firebase-database

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?542 kB? (?)
    apk (aggressive)?390 kB? (?)
    apk (release)?5.34 MB? (?)
  • firebase-database-collection

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?32.0 kB? (?)
    apk (aggressive)?318 kB? (?)
    apk (release)?1.86 MB? (?)
  • firebase-database-ktx

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.24 kB? (?)
    apk (aggressive)?391 kB? (?)
    apk (release)?5.34 MB? (?)
  • firebase-dataconnect

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?719 kB? (?)
    apk (aggressive)?520 kB? (?)
    apk (release)?11.0 MB? (?)
  • firebase-datatransport

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?4.28 kB? (?)
    apk (aggressive)?226 kB? (?)
    apk (release)?4.62 MB? (?)
  • firebase-decoders-json

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?7.85 kB? (?)
    apk (aggressive)?9.38 kB? (?)
    apk (release)?26.5 kB? (?)
  • firebase-dynamic-links

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?62.3 kB? (?)
    apk (aggressive)?387 kB? (?)
    apk (release)?4.89 MB? (?)
  • firebase-dynamic-links-ktx

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.61 kB? (?)
    apk (aggressive)?391 kB? (?)
    apk (release)?4.89 MB? (?)
  • firebase-dynamic-module-support

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?4.17 kB? (?)
    apk (aggressive)?157 kB? (?)
    apk (release)?4.52 MB? (?)
  • firebase-encoders

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    apk (aggressive)?9.38 kB? (?)
    apk (release)?27.2 kB? (?)
  • firebase-encoders-json

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?11.5 kB? (?)
    apk (aggressive)?20.8 kB? (?)
    apk (release)?2.01 MB? (?)
  • firebase-encoders-proto

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    apk (aggressive)?9.56 kB? (?)
    apk (release)?40.5 kB? (?)
  • firebase-encoders-reflective

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?7.97 kB? (?)
    apk (aggressive)?9.75 kB? (?)
    apk (release)?42.6 kB? (?)
  • firebase-firestore

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?1.44 MB? (?)
    apk (aggressive)?554 kB? (?)
    apk (release)?11.4 MB? (?)
  • firebase-firestore-ktx

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.23 kB? (?)
    apk (aggressive)?554 kB? (?)
    apk (release)?11.4 MB? (?)
  • firebase-functions

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?65.9 kB? (?)
    apk (aggressive)?440 kB? (?)
    apk (release)?5.44 MB? (?)
  • firebase-functions-ktx

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.24 kB? (?)
    apk (aggressive)?440 kB? (?)
    apk (release)?5.44 MB? (?)
  • firebase-inappmessaging

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?460 kB? (?)
    apk (aggressive)?1.05 MB? (?)
    apk (release)?11.7 MB? (?)
  • firebase-inappmessaging-display

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?163 kB? (?)
    apk (aggressive)?2.02 MB? (?)
    apk (release)?14.0 MB? (?)
  • firebase-inappmessaging-display-ktx

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.36 kB? (?)
    apk (aggressive)?2.02 MB? (?)
    apk (release)?14.0 MB? (?)
  • firebase-inappmessaging-ktx

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.27 kB? (?)
    apk (aggressive)?1.05 MB? (?)
    apk (release)?11.7 MB? (?)
  • firebase-installations

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?57.7 kB? (?)
    apk (aggressive)?148 kB? (?)
    apk (release)?4.46 MB? (?)
  • firebase-installations-interop

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?6.64 kB? (?)
    apk (aggressive)?73.1 kB? (?)
    apk (release)?1.40 MB? (?)
  • firebase-installations-ktx

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.20 kB? (?)
    apk (aggressive)?148 kB? (?)
    apk (release)?4.46 MB? (?)
  • firebase-messaging

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?148 kB? (?)
    apk (aggressive)?578 kB? (?)
    apk (release)?5.30 MB? (?)
  • firebase-messaging-directboot

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.20 kB? (?)
    apk (aggressive)?578 kB? (?)
    apk (release)?5.31 MB? (?)
  • firebase-messaging-ktx

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.54 kB? (?)
    apk (aggressive)?578 kB? (?)
    apk (release)?5.31 MB? (?)
  • firebase-ml-modeldownloader

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?125 kB? (?)
    apk (aggressive)?235 kB? (?)
    apk (release)?4.78 MB? (?)
  • firebase-ml-modeldownloader-ktx

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.60 kB? (?)
    apk (aggressive)?235 kB? (?)
    apk (release)?4.78 MB? (?)
  • firebase-perf

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?315 kB? (?)
    apk (aggressive)?1.57 MB? (?)
    apk (release)?9.06 MB? (?)
  • firebase-perf-ktx

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.21 kB? (?)
    apk (aggressive)?1.57 MB? (?)
    apk (release)?9.06 MB? (?)
  • firebase-sessions

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?168 kB? (?)
    apk (aggressive)?560 kB? (?)
    apk (release)?5.52 MB? (?)
  • firebase-storage

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?134 kB? (?)
    apk (aggressive)?399 kB? (?)
    apk (release)?5.04 MB? (?)
  • firebase-storage-ktx

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?3.24 kB? (?)
    apk (aggressive)?399 kB? (?)
    apk (release)?5.04 MB? (?)
  • firebase-vertexai

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?489 kB? (?)
    apk (aggressive)?479 kB? (?)
    apk (release)?9.30 MB? (?)
  • protolite-well-known-types

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?1.01 MB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?1.68 MB? (?)
  • transport-api

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?12.1 kB? (?)
    apk (aggressive)?9.38 kB? (?)
    apk (release)?31.4 kB? (?)
  • transport-backend-cct

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?72.9 kB? (?)
    apk (aggressive)?97.8 kB? (?)
    apk (release)?258 kB? (?)
  • transport-runtime

    TypeBase (ce7fb34)Merge (5dc1da3)Diff
    aar?163 kB? (?)
    apk (aggressive)?55.7 kB? (?)
    apk (release)?193 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/9q54Ohfwj7.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

This report is too large (219,975 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/pMRo9bIajb.html

@dconeybe
Copy link
Contributor Author

Please ignore the failing tests; they are failing due to lack of Any scalar support in the Android codegen. Support will go out in the next emulator release (see cl/676533430)

Copy link

@aashishpatil-g aashishpatil-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look very comprehensive !!

@dconeybe dconeybe merged commit 22a34d1 into dataconnect Sep 19, 2024
246 of 258 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/AnyScalarIntegrationTestOverhaul branch September 19, 2024 23:57
@firebase firebase locked and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants