-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul AnyScalarIntegrationTest.kt #6283
Merged
dconeybe
merged 2 commits into
dataconnect
from
dconeybe/dataconnect/AnyScalarIntegrationTestOverhaul
Sep 19, 2024
Merged
Overhaul AnyScalarIntegrationTest.kt #6283
dconeybe
merged 2 commits into
dataconnect
from
dconeybe/dataconnect/AnyScalarIntegrationTestOverhaul
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Size Report 1Affected Products
Test Logs |
Coverage Report 1This report is too large (219,975 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
Please ignore the failing tests; they are failing due to lack of |
aashishpatil-g
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look very comprehensive !!
dconeybe
deleted the
dconeybe/dataconnect/AnyScalarIntegrationTestOverhaul
branch
September 19, 2024 23:57
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares the tests for the upcoming tests that include codegen.
Googlers see b/361367932 for full details.