Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firebase-dataconnect merge into main branch #6290

Merged
merged 673 commits into from
Sep 25, 2024
Merged

firebase-dataconnect merge into main branch #6290

merged 673 commits into from
Sep 25, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Sep 21, 2024

Includes contributions by @cherylEnkidu

dconeybe added 30 commits May 2, 2024 13:41
… tests should never be mucking around with the default app
…he cli directly does not appear to pick up the value from .firebaserc
…edataconnect.googleapis.com" (was "dataconnect.googleapis.com")
…ect sdk prior to public announcements at i/o (#563)
Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Build files look fine to me. Still have pending work that needs @rachelsaunders input here, but otherwise I defer to @rlazo for final approval.

Also, worth looking at the smoke test failure. Those don't usually flake.

@dconeybe
Copy link
Contributor Author

dconeybe commented Sep 24, 2024

@rlazo I may need you to merge this PR for me because it won't let me because the cla presubmit is broken with such a large PR.

@dconeybe
Copy link
Contributor Author

dconeybe commented Sep 25, 2024

Also, worth looking at the smoke test failure. Those don't usually flake.

The most recent failure of the smoke test (at the time of writing) was due to this error:

This project's quota for this operation has been exceeded. [ Exceeded quota for verifying passwords. ]

(http://shortn/_hOLZ5pldH3)

A re-run fixed it.

Also, I've opened 2 PRs to fix flaky tests that I came across: #6290 and #6291. I'll continue to monitor the flaky failures.

Copy link
Contributor

@rachelsaunders rachelsaunders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The info in this changelog gets transformed into release notes displayed in the docs website. So it need to be markdown that renders appropriately. No raw URLs. Proper syntax, like backticks. Start the entry whenever possible with a verb in the past tense. Use proper brand names.

If you have the PR/Issue for each of these (except the "initial release" one), then please add that, too.

Thx!

firebase-dataconnect/CHANGELOG.md Outdated Show resolved Hide resolved
firebase-dataconnect/CHANGELOG.md Outdated Show resolved Hide resolved
firebase-dataconnect/CHANGELOG.md Outdated Show resolved Hide resolved
dconeybe and others added 4 commits September 25, 2024 04:52
Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
@dconeybe
Copy link
Contributor Author

@rachelsaunders

The info in this changelog gets transformed into release notes displayed in the docs website. So it need to be markdown that renders appropriately. No raw URLs. Proper syntax, like backticks. Start the entry whenever possible with a verb in the past tense. Use proper brand names.

If you have the PR/Issue for each of these (except the "initial release" one), then please add that, too.

Done. Please take a look at https://github.com/firebase/firebase-android-sdk/blob/dataconnect/firebase-dataconnect/CHANGELOG.md.

Also, do you know what values to specify for name.set and versionName.set in the releaseNotes section of firebase-dataconnect.gradle.kts? The values there are merely guesses on my part.

@rachelsaunders
Copy link
Contributor

@rachelsaunders

The info in this changelog gets transformed into release notes displayed in the docs website. So it need to be markdown that renders appropriately. No raw URLs. Proper syntax, like backticks. Start the entry whenever possible with a verb in the past tense. Use proper brand names.
If you have the PR/Issue for each of these (except the "initial release" one), then please add that, too.

Done. Please take a look at https://github.com/firebase/firebase-android-sdk/blob/dataconnect/firebase-dataconnect/CHANGELOG.md.

Beautiful :-D

Also, do you know what values to specify for name.set and versionName.set in the releaseNotes section of firebase-dataconnect.gradle.kts? The values there are merely guesses on my part.

This would be something that @daymxn or @rlazo can help you with.

@rlazo rlazo merged commit a95da3f into main Sep 25, 2024
261 of 263 checks passed
@rlazo rlazo deleted the dataconnect branch September 25, 2024 16:17
emilypgoogle pushed a commit that referenced this pull request Sep 25, 2024
Includes contributions by @cherylEnkidu

---------

Co-authored-by: cherylEnkidu <96084918+cherylEnkidu@users.noreply.github.com>
Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
emilypgoogle pushed a commit that referenced this pull request Sep 25, 2024
Includes contributions by @cherylEnkidu

---------

Co-authored-by: cherylEnkidu <96084918+cherylEnkidu@users.noreply.github.com>
Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants