Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CallerSdkType added #6298

Merged
merged 1 commit into from
Sep 24, 2024
Merged

CallerSdkType added #6298

merged 1 commit into from
Sep 24, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Sep 24, 2024

This refines the logic added in #6179 to have callers of FirebaseDataConnect.query() and FirebaseDataConnect.mutation() optionally specify a CallerSdkType enum instead of a GeneratedQuery or GeneratedMutation, respectively. This keeps the door open for a future possibility of having custom SDK types.

@dconeybe dconeybe self-assigned this Sep 24, 2024
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-dataconnect

    Overall coverage changed from ? (9f3210a) to 10.52% (6c2d67a) by ?.

    47 individual files with coverage change

    FilenameBase (9f3210a)Merge (6c2d67a)Diff
    AnyValue.kt?0.00%?
    AnyValueSerializer.kt?0.00%?
    Comparisons.kt?0.00%?
    ConnectorConfig.kt?33.33%?
    CoroutineExceptionHandler.kt?50.00%?
    DataConnectAppCheck.kt?0.00%?
    DataConnectAuth.kt?0.00%?
    DataConnectCredentialsTokenManager.kt?0.00%?
    DataConnectError.kt?0.00%?
    DataConnectException.kt?0.00%?
    DataConnectGrpcClient.kt?0.00%?
    DataConnectGrpcMetadata.kt?65.82%?
    DataConnectGrpcRPCs.kt?0.00%?
    DataConnectSettings.kt?33.33%?
    DataConnectUntypedData.kt?0.00%?
    DataConnectUntypedVariables.kt?0.00%?
    DateSerializer.kt?0.00%?
    FirebaseDataConnect.kt?56.25%?
    FirebaseDataConnectFactory.kt?29.17%?
    FirebaseDataConnectImpl.kt?38.05%?
    FirebaseDataConnectRegistrar.kt?100.00%?
    GeneratedConnector.kt?0.00%?
    GeneratedMutation.kt?0.00%?
    GeneratedOperation.kt?0.00%?
    GeneratedQuery.kt?0.00%?
    LiveQueries.kt?0.00%?
    LiveQuery.kt?0.00%?
    Logger.kt?52.17%?
    LogLevel.kt?100.00%?
    MutationRef.kt?0.00%?
    MutationRefImpl.kt?11.96%?
    OperationRef.kt?0.00%?
    OperationRefImpl.kt?20.93%?
    OptionalVariable.kt?0.00%?
    ProtoStructDecoder.kt?0.00%?
    ProtoStructEncoder.kt?0.00%?
    ProtoUtil.kt?0.00%?
    QueryManager.kt?0.00%?
    QueryRef.kt?0.00%?
    QueryRefImpl.kt?20.00%?
    QuerySubscription.kt?0.00%?
    QuerySubscriptionImpl.kt?0.00%?
    QuerySubscriptionInternal.kt?0.00%?
    RegisteredDataDeserialzer.kt?0.00%?
    TimestampSerializer.kt?0.00%?
    Util.kt?6.56%?
    UUIDSerializer.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YGea8aNMHV.html

Copy link
Contributor

Unit Test Results

  48 files   -   1 000    48 suites   - 1 000   1m 19s ⏱️ - 36m 17s
484 tests  -   5 326  484 ✔️  -   5 304  0 💤  - 21  0  - 1 
968 runs   - 11 043  968 ✔️  - 11 000  0 💤  - 42  0  - 1 

Results for commit e65d1aa. ± Comparison against base commit 9f3210a.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (9f3210a)Merge (6c2d67a)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)
  • firebase-dataconnect

    TypeBase (9f3210a)Merge (6c2d67a)Diff
    aar?683 kB? (?)
    apk (aggressive)?520 kB? (?)
    apk (release)?11.0 MB? (?)
  • protolite-well-known-types

    TypeBase (9f3210a)Merge (6c2d67a)Diff
    aar?1.01 MB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?1.68 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Bsk1ylHuVv.html

@dconeybe dconeybe merged commit 0466055 into dataconnect Sep 24, 2024
34 checks passed
@dconeybe dconeybe deleted the CallerSdkType branch September 24, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants